[#33396] - Joomla 4 - startTabSet() in some circumstances can return void
- Closed
- 29 Apr 2021
- Medium
- Build: 4.0.0 Beta 7
- # 33396
Steps to reproduce the issue
Component view html making use of Bootstrap tabs.
Expected result
startTabSet() to return a string or a raise a sensible exception.
Actual result
Get this message on screen:
Return value of Joomla\CMS\HTML\Helpers\Bootstrap::startTabSet() must be of the type string, none returned
System information (as much as possible)
PHP 7.4
Additional comments
Before closing braces should either return string or raise a sensible exception.
Votes
joomla-cms-bot
- 
Quy
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-28 21:11:39 |
| Closed_By | ⇒ | Quy |
Not tried fix, but problem in component was due to sometimes (!) startTabSet was being called twice with the same selector and params.
That was the problem I identified and debugged, my notes are in the PR. Thanks for confirming.
| Status | Closed | ⇒ | New |
| Closed_Date | 2021-04-28 21:11:39 | ⇒ | |
| Closed_By | Quy | ⇒ |
Thanks for reopening
The agreement made in #33397 is that this is probably a "Wont fix" and that developers should know not to use the same id multiple times.
However the thing we will fix is to die gracefully with either an exception thrown, or just to ignore the fact that you asked for a duplicate element with the same id - instead of a PHP error message which is not good enough really for Joomla.
alikon
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-29 17:00:04 |
| Closed_By | ⇒ | alikon |
What is the full content of your call including the selector and params?
Are you calling the method twice with the same selector and params?