[#33389] - [4.0] Edit User: Make the forms uniform
- Fixed in Code Base
- 28 Apr 2021
- Medium
- Build: 4.0-dev
- # 33389
- Diff
- YatharthVyas:user-edit-legends
User tests: Successful: Unsuccessful:
Pull Request for Issue #33378
Summary of Changes
Wrapped the form(s) for Account Details and Two Factor Authentication in <fieldset class="options-form"> <legend>
Added indentations on line 66 after if block opens and after uitab.addTab on lIne 67 to make the indentations consistent
Testing Instructions
Joomla Admin Panel -> Users -> Manage -> Click on a user to edit their profile
Verify that all forms follow a uniform style (fieldset with legends)
Note: You will have to enable 2FA to check the Two Factor Authentication tab or you can comment the following lines
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_users |
Made this: Note: You will have to enable 2FA to check the Two Factor Authentication tab ...
and maybe something wrong, as my Backend is broken now. Can't neither log out nor use Close button.
Will (or should) try to delete Plugin via phpMyAdmin. Never used 2FA before, but wanted to test this PR.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33389.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33389.
Made this: Note: You will have to enable 2FA to check the Two Factor Authentication tab ...
and maybe something wrong, as my Backend is broken now. Can't neither log out nor use Close button.
I was curious as to why this might've occurred and decided to give it a try myself:
For some reason, I wasn't able to reproduce this, added a gif below:
Will (or should) try to delete Plugin via phpMyAdmin. Never used 2FA before, but wanted to test this PR.
Yes please try that! I hope it fixes your backend. I'm sorry for the inconvenience caused and thanks for testing!
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33389.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33389.
@YatharthVyas
Thanks for your gif :-) Here my steps:
Authentication Methode selected: G Authenticator.
In Frontend: Logged In with the Security Code (Key) successfully.
But in Backend: Still no Log Out button and Close button didn‘t work.
Therefore I was searching then in phpMyAdmin for the correct table …..
plg_twofactorauth_totp = from enabled (1) changed to (0)
Backend was available again.
Under Users: Selected: Enforce Two Factor Authentication from „both“ back to: „No“
Guess won't attack 2FA anytime soon :-)
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-28 19:49:32 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
?
|
||
Thanks!
I have tested this item✅ successfully on 738c8f9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33389.