? ? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
27 Apr 2021

replacement for closed #33376 with changes

Summary of Changes

see #33376

  • Hides buttons in line with empty state design principle
  • slight code cleanup

Testing Instructions

see #33376

Actual result BEFORE applying this Pull Request

No empty state

Expected result AFTER applying this Pull Request

Empty state designed

Screenshot 2021-04-27 at 20 13 50

Screenshot 2021-04-27 at 20 13 42

avatar PhilETaylor PhilETaylor - open - 27 Apr 2021
avatar PhilETaylor PhilETaylor - change - 27 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Apr 2021
Category Administration com_banners Language & Strings
avatar PhilETaylor PhilETaylor - change - 27 Apr 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 27 Apr 2021
avatar Quy Quy - change - 28 Apr 2021
Labels Added: ? ?
avatar Quy Quy - test_item - 28 Apr 2021 - Tested successfully
avatar Quy
Quy - comment - 28 Apr 2021

I have tested this item successfully on b4404b7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33381.

avatar alikon alikon - test_item - 28 Apr 2021 - Tested successfully
avatar alikon
alikon - comment - 28 Apr 2021

I have tested this item successfully on b4404b7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33381.

avatar alikon alikon - change - 28 Apr 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 28 Apr 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33381.

avatar drmenzelit drmenzelit - change - 30 Apr 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-04-30 08:38:33
Closed_By drmenzelit
Labels Added: ?
avatar drmenzelit drmenzelit - close - 30 Apr 2021
avatar drmenzelit drmenzelit - merge - 30 Apr 2021
avatar drmenzelit
drmenzelit - comment - 30 Apr 2021

Thanks

Add a Comment

Login with GitHub to post a comment