? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
27 Apr 2021

Removing an unused file, as this project doesn't want to take code quality seriously.

avatar PhilETaylor PhilETaylor - open - 27 Apr 2021
avatar PhilETaylor PhilETaylor - change - 27 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Apr 2021
Category Repository
avatar brianteeman
brianteeman - comment - 27 Apr 2021

this should be closed. its just a petulant pr

avatar PhilETaylor
PhilETaylor - comment - 27 Apr 2021

This file is unused. It is not used by the Joomla project or the the drone/appveyour. It serves no purpose in this project's repository.

No other files would be allowed to be inserted into the repository if they did not have a good reason to be there, and were never used by developers or the drone/automation. Tell me Im wrong?! As much as I know you will hate to admit it, Im right here.

This file should be removed.

avatar joomdonation
joomdonation - comment - 27 Apr 2021

Came down @PhilETaylor . You know that we care about code quality, we just want to do a bit later to avoid merge conflicts as I mentioned somewhere.

avatar PhilETaylor
PhilETaylor - comment - 27 Apr 2021

we just want to do a bit later to avoid merge conflicts as I mentioned somewhere.

Same excuse as 5 years ago.

avatar joomdonation joomdonation - change - 1 May 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-05-01 05:02:00
Closed_By joomdonation
Labels Added: ?
avatar joomdonation joomdonation - close - 1 May 2021
avatar PhilETaylor
PhilETaylor - comment - 1 May 2021

I dont see why this was closed. This file is unused. It is not used by the Joomla project or the the drone/appveyour. It serves no purpose in this project's repository.

Please tell me why you are keeping this file?

avatar joomdonation
joomdonation - comment - 1 May 2021

It was created, so it was used. Maybe it is not used recently, but that doesn't mean we won't use it in the future, maybe when after Joomla 4 releases. There is no reason to delete it now, then create it again when we need to use it.

Add a Comment

Login with GitHub to post a comment