Feeling Lucky
?
[#3337] - [#33492] highlighter wrong pos (umlauts) and corrupted
- Closed
- 23 Mar 2014
- Medium
- Build: staging
- # 3337
- Diff
- unknown repository
- Foreign ID 33492
- Error The Travis CI build could not complete due to an error Details
User tests: Successful: Unsuccessful:
com_search
1) highlighter SPANs wrong position with german umlauts
2) corrupted highlighter SPANs if overlapping searchwords
| Title |
|
||||||
| Labels |
Added:
?
?
|
||||||
illovo
- comment
- 23 Mar 2014
Sorry, but I won't. For me it looks fine and I don't have the time to read instructions about correct linebreaks. I've closed the PR instead.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-03-23 02:32:48 |
zero-24
- comment
- 3 Sep 2014
New PR with CS fixes are here: #4216 I hope you can test the new PR and comment on it.
If you don't know how you can test a PR you can use com_patchtester: http://docs.joomla.org/Component_Patchtester_for_Testers
thanks @illovo
Please make sure to apply some proper coding styles (http://docs.joomla.org/Coding_style_and_standards) and update your patch accordingly. There are some missing spaces and linebrakes, some waste indents and wrong comments. Thanks!