? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
26 Apr 2021

[4] Add trailing comma to array to comply with CodeStyle

Code Review

avatar PhilETaylor PhilETaylor - open - 26 Apr 2021
avatar PhilETaylor PhilETaylor - change - 26 Apr 2021
Status New Pending
avatar brianteeman
brianteeman - comment - 26 Apr 2021

loving how you suggested I closed my pr that did all this sort of stuff.

avatar PhilETaylor
PhilETaylor - comment - 26 Apr 2021

I don't think I did? Infact I think I actually gave you the instructions on how to run the commands yourself. Including how to run the old version Joomla provides

Sorry if you feel put out because of that

In fact you said in #33335

I don't have the time but I do want to learn and save myself time in the future. So thats what I am looking at

So I assumed you were not going to follow the instructions I provided. Ah well.

I said

If I were you, and I had time [...]

There is plenty that needs doing - I was bored sat in the car on the laptop waiting for kid to finish extracurricular activities so had a stab

[...] I would improve the configuration of phpcs, with native_function_invocation

Which I have done here: #33348

and including all the core Joomla folders and run it, and prepare a PR with the results.

Which I started doing.

avatar Quy Quy - test_item - 26 Apr 2021 - Tested successfully
avatar Quy
Quy - comment - 26 Apr 2021

I have tested this item successfully on 3f32088


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33352.

avatar PhilETaylor
PhilETaylor - comment - 27 Apr 2021

Closing as no one has the balls to merge this.

avatar PhilETaylor PhilETaylor - change - 27 Apr 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-04-27 14:03:49
Closed_By PhilETaylor
Labels Added: ?
avatar PhilETaylor PhilETaylor - close - 27 Apr 2021

Add a Comment

Login with GitHub to post a comment