Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#33339] - [4.0] REST semantic Provide Sensible Resource Names

? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
26 Apr 2021

Pull Request for Issue #33336 .

Summary of Changes

from GET /api/index.php/v1/installer/manage
to GET /api/index.php/v1/extensions

Testing Instructions

read #33336
or test the endpoint :

  • GET {{base_path}}/api/index.php/v1/extensions?core=true/false
  • GET {{base_path}}/api/index.php/v1/extensions?status=0/1
  • GET {{base_path}}/api/index.php/v1/extensions?type=component/plugin/module/template

Documentation Changes Required

already undocumented but should be

avatar alikon alikon - open - 26 Apr 2021
avatar alikon alikon - change - 26 Apr 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Apr 2021
Category ⇒ Front End Plugins
avatar alikon alikon - change - 26 Apr 2021
Labels Added: ?
avatar alikon alikon - change - 26 Apr 2021
The description was changed
avatar alikon alikon - edited - 26 Apr 2021
avatar alikon alikon - change - 26 Apr 2021
The description was changed
avatar alikon alikon - edited - 26 Apr 2021
avatar anibalsanchez anibalsanchez - test_item - 1 May 2021 - Tested unsuccessfully
avatar anibalsanchez
anibalsanchez - comment - 1 May 2021

I have tested this item ? unsuccessfully on 9b7acd4

It seems that I always get the same response and it doesn't use the filters:

curl -H "Authorization: Bearer ...." -X GET "http://.../api/index.php/v1/extensions?core=true"

curl -H "Authorization: Bearer ..." -X GET "http://.../api/index.php/v1/extensions?core=false"

curl -H "Authorization: Bearer ..." -X GET "http://.../api/index.php/v1/extensions?status=1"

curl -H "Authorization: Bearer ..." -X GET "http://.../api/index.php/v1/extensions?status=0"
avatar alikon alikon - change - 9 May 2021
The description was changed
avatar alikon alikon - edited - 9 May 2021
avatar alikon
alikon - comment - 9 May 2021

@anibalsanchez can you please retest, now just 1 pr ?

avatar carcam carcam - test_item - 14 May 2021 - Tested successfully
avatar carcam
carcam - comment - 14 May 2021

I have tested this item ✅ successfully on 3404118

I have tested the 3 poposed endpoints with their filters and it returns different content according to each of the proposed filters.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33339.

avatar BertaOctech BertaOctech - test_item - 14 May 2021 - Tested successfully
avatar BertaOctech
BertaOctech - comment - 14 May 2021

I have tested this item ✅ successfully on 3404118

Before applying the patch I did not manage to get any answer from the API
After applying the patch, I got correct filtered data in response to

curl -H "Authorization: Bearer XXXXXX" http://localhost/demo_j4/api/index.php/v1/extensions?status=1

and

curl -H "Authorization: Bearer XXXXXX" http://localhost/demo_j4/api/index.php/v1/extensions?status=0

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33339.

avatar richard67 richard67 - change - 14 May 2021
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 14 May 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33339.

avatar wilsonge wilsonge - change - 15 May 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-05-15 11:46:56
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 15 May 2021
avatar wilsonge wilsonge - merge - 15 May 2021
avatar wilsonge
wilsonge - comment - 15 May 2021

Thanks!

avatar PhilETaylor
PhilETaylor - comment - 19 May 2021

Just a quick follow up

The code merged was totally wrong.

$this->modelState->set('filter.status', $this->input->get('status', $this->input->get->get('status')), 'INT');
$this->modelState->set('filter.type', $this->input->get('type', $this->input->get->get('type')), 'STRING');

Those type hints at the end are wrong - Im fixing it in #33960 so follow along there if interested.

Add a Comment

Login with GitHub to post a comment