?
avatar brianteeman
brianteeman
25 Apr 2021

@Bakual my turn to say sorry I didnt check it before it was merged.

If you are in a modal when you click on the "add your first..." then the resultant page is the full page not the modal. See video

Actual Result

modal

Expected Result

image

avatar brianteeman brianteeman - open - 25 Apr 2021
avatar joomla-cms-bot joomla-cms-bot - change - 25 Apr 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 25 Apr 2021
avatar Bakual
Bakual - comment - 25 Apr 2021

Good find. Simplest fix would be to not show the create button when in a modal. Because you should actually use the "Create" button in the menuitem form to create a new article.
We could also add a conditional in the view to only load the blankstate layout if not in a modal. We have such conditials already there to avoid loading the toolbar.
Loading the article form in the modal will probably get dirty as the current modal doesn't have any save buttons ?

I'm not sure what the expected behavior would be.

avatar PhilETaylor
PhilETaylor - comment - 25 Apr 2021

I'll leave you @Bakual to look at this one, my bed and then the day job tomorrow is now calling me and taking my time.

avatar Bakual
Bakual - comment - 26 Apr 2021

Decided to not show the button when in a modal: #33331

avatar brianteeman brianteeman - change - 26 Apr 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-04-26 06:54:22
Closed_By brianteeman
avatar brianteeman brianteeman - close - 26 Apr 2021

Add a Comment

Login with GitHub to post a comment