[#33317] - [4.0] Toolbar Close/Cancel
- Fixed in Code Base
- 26 Apr 2021
- Medium
- Build: 4.0-dev
- # 33317
- Diff
- brianteeman:buttons
User tests: Successful: Unsuccessful:
The cancel button should have the text
Cancel when its a new item
Close when its an existing item
With this PR I have fixed the few instances that incorrectly did not follow this pattern which is used in all the other 33 views.
Summary of changes
Create a New Article - Cancel
Edit an Article - Close
Create a Workflow - Cancel
Edit a Workflow - Close
Create a Workflow Stage - Cancel
Edit a Workflow Stage - Close
Create a Workflow Transition - Cancel
Edit a Workflow Transition - Close
Edit an image - Close
Create a private message - Cancel
Read a private message - Close
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content com_media com_messages com_workflow |
| Labels |
Added:
?
|
||
Article should be fixed now. Its slightly different in that component for reasons that are beyond me.
fixed typo in description
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33317.
I have not tested this item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33317.
Please fix PHP CS as suggested above.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33317.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33317.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33317.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-26 13:03:15 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
Thanks
thx
@brianteeman I've just tested:
2 of the things in your list don't work for me:
The rest is as described.