[#3331] - RSS Feed with Unicode Alias fails to validate [#33478]
- Closed
- 19 Mar 2014
- Medium
- Build: staging
- # 3331
- Diff
- rishantagarwal:first-test
- Foreign ID 33478
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Tracker code : # 33478
Joomla RSS feed contains invalid UTF-8 characters in URL, these fail validation and prevent certain libraries from using the feeds.
Assuming you have a category ID 173 which contains an article with an unicode alias, with an url like:
http://example.com/index.php?option=com_content&view=category&id=173&format=feed&type=rss&lang=en
http://validator.w3.org/feed will return the following errors:
This feed does not validate.
line 25, column 101: link must be a full and valid URL: http://example.com/company/news/1185-soso-ibérica-opens-new-fishing-garden
line 26, column 120: guid must be a full URL, unless isPermaLink attribute is false: http://example.com/company/news/1185-soso-ibérica-opens-new-fishing-garden
How to reproduce the problem and/or test the patch::
Setup a Joomla 3.2.3 with unicode aliases enabled in the global configuration; Create an article with a unicode character in the alias e.g. 'à' Run the rss feed through http://validator.w3.org/feed It will fail to validate both (link) and (guid)
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-03-19 09:21:52 |
| Status | Closed | ⇒ | New |
There is some difference in the code in both the files. Please have a look into it.
@infograf768 Can you check if this solution is better than yours? I think we should only have one PR active.
@bindasrishant I saw that you used spaces to indent the code. We use tabs instead according to out coding standards (http://joomla.github.io/coding-standards/). Can you please update the PR with that?
I also noted that the other PR from Jean-Marie does the change for both RSS and Atom feeds, while yours only changes RSS. I think it does make sense to apply this change to both feed types?
This PR does not work at all, not only the issue with deprecated function split(), but also the str_replace, etc.
Mine needs more improvements to get full validation.
I replicated issue, tested patch 3331, and found it resolves the issue.
You may blame the J!Tracker Application for transmitting this comment.
| Status | New | ⇒ | Closed |
| Closed_Date | 2014-03-19 09:21:52 | ⇒ | 2014-03-19 20:25:35 |
Please test again, sef on and sef off (I improved the PR)
#3320
And comment in tracker
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33478&start=0
That's the same as #3320?