No Code Attached Yet
avatar PhilETaylor
PhilETaylor
25 Apr 2021

Steps to reproduce the issue

"Most" flash error/warning/info messages are a single line of text

Expected result

Pixel Perfection™

The
Screenshot 2021-04-25 at 17 15 13
in the left of the message to be in line with the first line of text - thus in the middle of the coloured block when the error message is a single line, and in line with the first sentence if the error message is longer than one line of text

Actual result

Screenshot 2021-04-25 at 17 12 51

Screenshot 2021-04-25 at 17 16 31

System information (as much as possible)

safari on mac.

Additional comments

Needs to be fixed generically so applies to all error/warning and info messages

avatar PhilETaylor PhilETaylor - open - 25 Apr 2021
avatar joomla-cms-bot joomla-cms-bot - change - 25 Apr 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 25 Apr 2021
avatar PhilETaylor PhilETaylor - change - 25 Apr 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 25 Apr 2021
avatar PhilETaylor PhilETaylor - change - 25 Apr 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 25 Apr 2021
avatar PhilETaylor PhilETaylor - change - 25 Apr 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 25 Apr 2021
avatar dgrammatiko
dgrammatiko - comment - 25 Apr 2021

Will fix this on #33234

avatar brianteeman
brianteeman - comment - 7 May 2021

To be clear is this what you want
image

its just a padding issue

avatar PhilETaylor
PhilETaylor - comment - 7 May 2021

99% of the messages in Joomla on a normal screen width are one line messages so if padding works then great.

Does it still work correctly (in line with the first sentence, and not in the middle like the screenshot above shows) when:

  • On a small screen so one sentence is wrapped
  • On a multi sentence message
avatar brianteeman
brianteeman - comment - 7 May 2021

no this change would not make the icon in line with the first sentence. Not convinced that it would be better or more correct. BS5 keeps it centered by default

image

avatar dgrammatiko
dgrammatiko - comment - 8 May 2021

BS5 keeps it centered by default

These are not Bootstrap...

avatar brianteeman
brianteeman - comment - 8 May 2021

I know it was more a comment to say that the statement that it would be more correct if it was aligned with the top sentence was not necessarily true

avatar PhilETaylor PhilETaylor - change - 7 Mar 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-03-07 18:37:46
Closed_By PhilETaylor
Labels Added: No Code Attached Yet
Removed: ?
avatar PhilETaylor PhilETaylor - close - 7 Mar 2022

Add a Comment

Login with GitHub to post a comment