Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#33302] - [4.0] Fix setError call

? ? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
25 Apr 2021

Pull Request for Issue # .

Summary of Changes

setError method only accept one parameter but on some calls, we are passing two parameters to it. This PR just fixes that small error.

Testing Instructions

Code review.

avatar joomdonation joomdonation - open - 25 Apr 2021
avatar joomdonation joomdonation - change - 25 Apr 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Apr 2021
Category ⇒ Front End com_users
avatar richard67
richard67 - comment - 25 Apr 2021

@joomdonation Where can we see that the function accepts only 1 parameter, i.e. where is it defined?

avatar richard67 richard67 - test_item - 25 Apr 2021 - Tested successfully
avatar richard67
richard67 - comment - 25 Apr 2021

I have tested this item ✅ successfully on e9065b4

Code review: As far as I could see, this PR covers all cases with the wrong 2nd parameter.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33302.

avatar Quy Quy - test_item - 25 Apr 2021 - Tested successfully
avatar Quy
Quy - comment - 25 Apr 2021

I have tested this item ✅ successfully on e9065b4

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33302.

avatar Quy Quy - change - 25 Apr 2021
Status Pending ⇒ Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 25 Apr 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33302.

avatar chmst chmst - close - 25 Apr 2021
avatar chmst chmst - merge - 25 Apr 2021
avatar chmst chmst - change - 25 Apr 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-04-25 16:05:56
Closed_By ⇒ chmst
Labels Added: ?

Add a Comment

Login with GitHub to post a comment