[#33300] - [4.0] com_postinstall: Display "Showing messages for" dropdown only if there's more than 1 options
- Fixed in Code Base
- 25 Apr 2021
- Medium
- Build: 4.0-dev
- # 33300
- Diff
- YatharthVyas:post-install-dropdown
User tests: Successful: Unsuccessful:
Pull Request for Issue #33291 .
Summary of Changes
Added a check to hide the dropdown form if the count of $this->extensions_options is not > 1 by setting it's class to .visually-hidden
Reference: $this->extension_options is given it's value by getComponentOptions() function in MessageModel.php where it's defined as an array so the count has to be 0 or more (an integer)
Testing Instructions
- Joomla Admin Panel
- Select Post Installation messages (located on the top right)
- The dropdown and text will be visible only if the select-able options are >1
Actual result BEFORE applying this Pull Request
Link if the above image is broken: https://ibb.co/7Kk0Mt5
Expected result AFTER applying this Pull Request
Link if the above image is broken: https://ibb.co/yVQWQD0
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_postinstall |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33300.
I have tested this item
Thanks @YatharthVyas
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33300.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33300.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-25 14:25:39 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
Removed: ? |
||
Thanks
I have tested this item? unsuccessfully on 2956f26
Click on
Hide all Messagesdon't work and give a js-error:This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33300.