J4 Issue ? ?
avatar brianteeman
brianteeman
25 Apr 2021

Multiple issues

Featured Article

1. Icon uses color alone to indicate its status
2. Screen reader only announces "Toggle Featured Status" - it does not announce if it is featured or not
3. Still uses bootstrap tooltip

image

Featured Contact

1. icon uses color alone to indicate its status
2. Screen reader only announces "Feature Item" or "Unfeature item" - it does not announce if it is featured or not

image

Summary

- Update icon

  • announce both the current state and what the button will do
  • consistent terminology

updated after #33417

avatar brianteeman brianteeman - open - 25 Apr 2021
avatar joomla-cms-bot joomla-cms-bot - change - 25 Apr 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 25 Apr 2021
avatar brianteeman brianteeman - change - 25 Apr 2021
The description was changed
avatar brianteeman brianteeman - edited - 25 Apr 2021
avatar brianteeman brianteeman - change - 25 Apr 2021
The description was changed
avatar brianteeman brianteeman - edited - 25 Apr 2021
avatar himanshu007-creator
himanshu007-creator - comment - 25 Apr 2021

To solve this, an approach can be using different but similar icons for featured and unfeatured status of article.
featured state icon:- https://fontawesome.com/icons/lightbulb-on?style=solid
unfeatured state icon:- https://fontawesome.com/icons/lightbulb-slash?style=duotone

On screen , it will go like:-

state: <present state>
click to toggle

avatar richard67
richard67 - comment - 25 Apr 2021

@himanshu007-creator The icons you are suggesting belong to the "pro" package of fontawesome, which is a paid one. We only ship the free ones, "standard", "solid" and "brands".

avatar chmst chmst - change - 25 Apr 2021
Labels Added: J4 Issue ?
avatar chmst chmst - labeled - 25 Apr 2021
avatar chmst chmst - labeled - 25 Apr 2021
avatar chmst
chmst - comment - 25 Apr 2021

We could show no star at all if an item is not featured.

avatar himanshu007-creator
himanshu007-creator - comment - 25 Apr 2021

@himanshu007-creator The icons you are suggesting belong to the "pro" package of fontawesome, which is a paid one. We only ship the free ones, "standard", "solid" and "brands".

Okay, if that is the case, maybe an eye icon will do the job! Moreover , it will look quite self explanatory as well!
featured state icon-https://fontawesome.com/icons/eye?style=solid
unfeatured state icon- https://fontawesome.com/icons/low-vision?style=solid

views:-
featured
unfeatured

avatar PhilETaylor
PhilETaylor - comment - 25 Apr 2021

Not only the featured articles icon - if you go to Template Styles here is the same issue with the default icon

Screenshot 2021-04-25 at 16 28 24

avatar PhilETaylor
PhilETaylor - comment - 25 Apr 2021

Okay, if that is the case, maybe an eye icon will do the job!

"Eye" is used for "preview" elsewhere in Joomla - Eg, the template styles screenshot I just posted

avatar himanshu007-creator
himanshu007-creator - comment - 25 Apr 2021

Okay, if that is the case, maybe an eye icon will do the job!

"Eye" is used for "preview" elsewhere in Joomla - Eg, the template styles screenshot I just posted

we can change the default icon here as well to a single tick icon like this
A site can have many published articles, but there is only one default template for a category (site of admin). For this case we can use a single tick in front of the template selected as default and for rest templates, leave it blank.
2021-04-25 (2)

avatar carcam
carcam - comment - 26 Apr 2021

Featured and default are different states. So having different icons for them makes total sense.

Looking for options and taking into account that an article can be featured in a specific container and it's like a windows shop, I think the store icons could do the job:

https://fontawesome.com/icons/store-slash?style=solid

https://fontawesome.com/icons/store?style=solid

For template manager, I will leave the tick for default and an empty circle for non-default items.

avatar chmst
chmst - comment - 26 Apr 2021

Agree that featured and default are different.

I prefer the star as it is for feaured items, this is a common icon and users know it.
If an item is not featured, we could use the "disc" - this is also common and known - used in menu items overview.

avatar alikon alikon - change - 30 Apr 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-04-30 06:49:11
Closed_By alikon
Labels Added: ?
Removed: ?
avatar alikon alikon - close - 30 Apr 2021
avatar alikon
alikon - comment - 30 Apr 2021

please test #33417

avatar richard67 richard67 - change - 30 Apr 2021
Status Closed New
Closed_Date 2021-04-30 06:49:11
Closed_By alikon
Labels Added: ?
Removed: ?
avatar richard67 richard67 - reopen - 30 Apr 2021
avatar richard67
richard67 - comment - 30 Apr 2021

Re-opening since PR #33417 is only for parts of this issue, see #33417 (comment) .

avatar brianteeman brianteeman - change - 30 Apr 2021
The description was changed
avatar brianteeman brianteeman - edited - 30 Apr 2021
avatar brianteeman
brianteeman - comment - 30 Apr 2021

thanks @richard67 I have updated the original post

avatar chmst
chmst - comment - 30 Apr 2021

I have stopped working on the issue as @brianteeman took over.

avatar brianteeman
brianteeman - comment - 30 Apr 2021

Sorry. I didn't know you were working on it. You didn't say anything.

avatar richard67
richard67 - comment - 30 Apr 2021

She had assigned the issue to herself, which was visible on GitHub by the "asignee".

avatar brianteeman
brianteeman - comment - 30 Apr 2021

when did we start using that? also its not very productive as only a limited few people can even use it

avatar richard67
richard67 - comment - 30 Apr 2021

We started to use it years ago, but you are right, we used it only in rare cases.

avatar chmst
chmst - comment - 30 Apr 2021

Indeed it is not as easy to solve this issue, but important - because the tooltips also are different for workflow on/off.

avatar brianteeman
brianteeman - comment - 30 Apr 2021

Once again apologies for not seeing the assignment. Might be a good idea for you to review the current assignments ;)

avatar chmst
chmst - comment - 30 Apr 2021

no problem - now as your changes of the icon are merged I can continue.

avatar brianteeman
brianteeman - comment - 30 Apr 2021

sorry once again

avatar sandramay0905
sandramay0905 - comment - 30 Apr 2021

@chmst i fear it will happen again cause the self-assign isn't shown on top:

image

avatar richard67
richard67 - comment - 30 Apr 2021

@sandramay0905 That's because I have remove the assignment after @chmst had asked me on Glip to do so.

avatar sandramay0905
sandramay0905 - comment - 30 Apr 2021

@richard67 sorry, i thought its a general problem. Thanks for the information :-)

avatar chmst chmst - change - 5 May 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-05-05 10:13:55
Closed_By chmst
Labels Added: ?
Removed: ?
avatar chmst
chmst - comment - 5 May 2021

Closing as there is a PR

avatar chmst chmst - close - 5 May 2021
avatar richard67
richard67 - comment - 5 May 2021

See #33557 .

Add a Comment

Login with GitHub to post a comment