? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
24 Apr 2021

Summary of Changes

Correct the link in the top menu bar to remove superfluous detail, which when appended, causes the left menu to collapse

id is not needed, we know who we are based on the session data

return is only needed if we were redirecting to a form that had a save/cancel action

Whitespace at the end of the file also removed (automatically by #phpStorm because its amazing)

Testing Instructions

Click Private Messages icon in the header top right

Actual result BEFORE applying this Pull Request

Left menu collapses regardless of where you are

Expected result AFTER applying this Pull Request

Left menu highlights Private Messages menu item and you see only your messages

Documentation Changes Required

avatar PhilETaylor PhilETaylor - open - 24 Apr 2021
avatar PhilETaylor PhilETaylor - change - 24 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Apr 2021
Category Modules Administration
avatar ChristineWk ChristineWk - test_item - 24 Apr 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 24 Apr 2021

I have tested this item successfully on 85f1d9d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33285.

avatar PhilETaylor PhilETaylor - change - 24 Apr 2021
Labels Added: ?
avatar ChristineWk ChristineWk - test_item - 24 Apr 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 24 Apr 2021

I have tested this item successfully on d07af3b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33285.

avatar Quy Quy - test_item - 25 Apr 2021 - Tested successfully
avatar Quy
Quy - comment - 25 Apr 2021

I have tested this item successfully on d07af3b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33285.

avatar Quy Quy - change - 25 Apr 2021
Status Pending Ready to Commit
avatar Quy
Quy - comment - 25 Apr 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33285.

avatar rdeutz rdeutz - close - 25 Apr 2021
avatar rdeutz rdeutz - merge - 25 Apr 2021
avatar rdeutz rdeutz - change - 25 Apr 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-04-25 10:10:16
Closed_By rdeutz
Labels Added: ?

Add a Comment

Login with GitHub to post a comment