? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
24 Apr 2021

Summary of Changes

Logrotation currently uses the Joomla framework Filesystem package which is not FTP Layer aware.

This leads to issues when log rotation attempts to move a file when it has no permissions to do so, when FTP is needed.

This change starts using the Folder and File packages from the CMS and not the framework, although Folder doesn't yet need to be FTP aware, Im changing that so that if we ever did make Folder FTP Aware (hint: probably soon coming!) then it will "just work" in future.

Testing Instructions

Code review, unless you have a spare hour to follow along the whole FTP Layer set up.

Actual result BEFORE applying this Pull Request

After installation, and clocking on the Open Site button on the last page of the installation wizard

Screenshot 2021-04-24 at 17 42 51

Expected result AFTER applying this Pull Request

Use the CMS Filesystem lib, which is FTP aware, and can move the file with FTP.

Documentation Changes Required

none

avatar PhilETaylor PhilETaylor - open - 24 Apr 2021
avatar PhilETaylor PhilETaylor - change - 24 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Apr 2021
Category Front End Plugins
avatar wilsonge wilsonge - change - 24 Apr 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-04-24 21:59:14
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 24 Apr 2021
avatar wilsonge wilsonge - merge - 24 Apr 2021
avatar wilsonge
wilsonge - comment - 24 Apr 2021

Thanks!

Add a Comment

Login with GitHub to post a comment