[#33281] - [4.0] Fix Update Joomla Using FTP
- Closed
- 30 Apr 2021
- Medium
- Build: 4.0-dev
- # 33281
- Diff
- joomdonation:update_joomla_using_ftp_fix
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
During update process (using FTP or Hybrid installation method), Joomla! needs to write FTP credentials into restoration.php file so that these data can be used by restore.php on restoration process.
Due to a bug in getting FTP credentials (trying to get directly from input but these fields are not available in the input at all), update Joomla using these two methods never works (or at least it never works in the recent version). Also, the code in restore.php file does not like the path with window style, so I added some code to change it to Linux path style
Tested on my local Joomla 4 using Filezilla server and it worked. Not sure how to give testing instructions because now it is hard to find testers for FTP stuffs.
Testing Instructions
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
Yes, same happens with Joomla 3. I just made the PR here quickly to prove that updates Joomla never works properly (at least for recent release, maybe from the time we added Upload and Update option back, I don't remember the time)
So the point here is if update is not working and no-one reports it, can we assume that no-one is using it? We can try to spend time to fix FTP issues, but if no one is using it, it will be a waste of time
So the point here is if update is not working and no-one reports it, can we assume that no-one is using it? We can try to spend time to fix FTP issues, but if no one is using it, it will be a waste of time
That's what I've been trying to say but people keep sidetracking with conversations about code purity
Hope this PR shows something. If update Joomla not working, if install extensions not working (as I saw somewhere from list of issues which Phil mentioned) and no-one complains, we should not have to spend time to fix it.
we should not have to spend time to fix it.
it will be a waste of time
I think Im going to log off now :) :)
I'll add this PR to the list at #33251
because now it is hard to find testers for FTP stuffs.
Because very few people even understand the root problem, and others view it as a server "misconfiguration", a "botched installation" of a server instead of a genuine type of server configuration (from 15 years ago)...
Drone died but unrelated
Drone resuscitated
Closing because FTP layer will be dropped.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-30 10:30:16 |
| Closed_By | ⇒ | joomdonation | |
| Labels |
Added:
?
|
||
Closing because FTP layer will be dropped.
@joomdonation Who says that?
Following the projects decision to remove the FTP Layer from Joomla 4
Doesn't the same problem exist in Joomla 3? At least from your description of the reason it would appear so.