Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#33267] - margin added in joomla-toolbar-button

NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar rjharishabh
rjharishabh
23 Apr 2021

Summary of Changes

.btn-toolbar{
  joomla-toolbar-button{
    margin:0.25rem;
  }
}

Testing Instructions

  • Apply PR
  • Do npm run build:css
  • Log In to the frontend
  • Go to Template Setting in Author Menu model (If you have added it).

Actual result BEFORE applying this Pull Request

No margin applied to buttons

Expected result AFTER applying this Pull Request

margin applied to buttons

Documentation Changes Required

None

Don't know whether I'm editing the right file or not.

avatar rjharishabh rjharishabh - open - 23 Apr 2021
avatar rjharishabh rjharishabh - change - 23 Apr 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Apr 2021
Category ⇒ Front End Templates (site) NPM Change
avatar rjharishabh rjharishabh - change - 23 Apr 2021
The description was changed
avatar rjharishabh rjharishabh - edited - 23 Apr 2021
avatar rjharishabh rjharishabh - change - 23 Apr 2021
Labels Added: NPM Resource Changed ?
avatar brianteeman
brianteeman - comment - 23 Apr 2021

Thanks for your contribution but I believe this has already been resolved and your branch is not up to date. This is the PR that fixed it #33231

As you will see the problem was a missing class

avatar rjharishabh
rjharishabh - comment - 23 Apr 2021

Thanks @brianteeman

avatar rjharishabh rjharishabh - close - 23 Apr 2021
avatar rjharishabh rjharishabh - change - 23 Apr 2021
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-04-23 16:40:02
Closed_By ⇒ rjharishabh
avatar rjharishabh rjharishabh - change - 23 Apr 2021
The description was changed
avatar rjharishabh rjharishabh - edited - 23 Apr 2021
avatar rjharishabh rjharishabh - change - 23 Apr 2021
The description was changed
avatar rjharishabh rjharishabh - edited - 23 Apr 2021

Add a Comment

Login with GitHub to post a comment