[#33262] - [4.0] Subform Cleanup
- Fixed in Code Base
- 24 Apr 2021
- Medium
- Build: 4.0-dev
- # 33262
- Diff
- joomdonation:subform_cleanup
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
In the PR #33200 (which was merged), I renamed the plugin from Subfields to Subform. However, there are still few instances of Subfields which should be updated to Subform. This PR just makes that final clean up.
Testing Instructions
- In update package for the original PR https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/33200/downloads/42161/Joomla_4.0.0-beta8-dev+pr.33200-Development-Update_Package.zip . You can go to System -> Update -> Joomla to update that package
- Access to Content -> Fields, create a new Subform custom field
- Before patch, in the Fields setting of that Subform custom field, you can choose the same field multiple times and the system still save it
- After patch, if you choose same field multiple times, only one will be saved
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields Front End Plugins |
| Labels |
Added:
?
|
||
By "Subform custom field" do you mean a "Subfields" custom field?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33262.
Also, I'm getting 404 not found for:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33262.
Please use the download link at the bottom of the page.
What is the URL of the page with the Download link?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33262.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33262.
| Status | Pending | ⇒ | Ready to Commit |
RTC again (somehow the bot removed it)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33262.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-24 09:22:48 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/33262/downloads/42332/
When I go to the above URL and try to download the update package, I get:
**Not Found
The requested URL was not found on this server.**
Download link:
Thanks @eddiekonczal. This PR was merged, so we do not need to test it anymore.
You can of course use the Nightly build if you want to see this now its merged https://developer.joomla.org/nightlies/Joomla_4.0.0-beta8-dev-Development-Full_Package.zip
I have tested this item✅ successfully on 4dc9a40
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33262.