? ? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
23 Apr 2021

Summary of Changes

Adds a unit test for ModuleAdapter::getElement that was useful when refactoring the code in #33182

Testing Instructions

The tests pass before refactoring

Apply PR: #33182

The tests pass after refactoring

Actual result BEFORE applying this Pull Request

The tests pass before refactoring

Expected result AFTER applying this Pull Request

The tests pass after refactoring

Documentation Changes Required

avatar PhilETaylor PhilETaylor - open - 23 Apr 2021
avatar richard67 richard67 - test_item - 23 Apr 2021 - Tested successfully
avatar richard67
richard67 - comment - 23 Apr 2021

I have tested this item successfully on e49f156

New unit tests are run and pass when the other PR is applied and this one, too. I've run them on my local environment.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33260.

avatar dgrammatiko dgrammatiko - test_item - 23 Apr 2021 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 23 Apr 2021

I have tested this item successfully on e49f156


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33260.

avatar richard67 richard67 - change - 23 Apr 2021
Category Unit Tests
avatar richard67 richard67 - change - 23 Apr 2021
The description was changed
Status New Ready to Commit
Labels Added: ?
avatar richard67 richard67 - edited - 23 Apr 2021
avatar richard67
richard67 - comment - 23 Apr 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33260.

avatar wilsonge wilsonge - change - 23 Apr 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-04-23 19:29:16
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 23 Apr 2021
avatar wilsonge wilsonge - merge - 23 Apr 2021
avatar wilsonge
wilsonge - comment - 23 Apr 2021

Thankyou!

Add a Comment

Login with GitHub to post a comment