?
avatar PhilETaylor
PhilETaylor
22 Apr 2021

Steps to reproduce the issue

Install Joomla 4 on a server that requires the use of the FTP Layer (see #31857)

Go to Joomla Global Config and save

Expected result

When checking if folder paths are writable, consideration should be given to the FTP Layer status.

Global configuration is saved
Green feedback message

Actual result

ApplicationModel.php uses is_writable to check paths, which returns false (as FTP is needed to write to folders!)

if (!is_dir($path) || !is_writable($path))

Screenshot 2021-04-22 at 17 42 41

System information (as much as possible)

Additional comments

avatar PhilETaylor PhilETaylor - open - 22 Apr 2021
avatar joomla-cms-bot joomla-cms-bot - change - 22 Apr 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 22 Apr 2021
avatar PhilETaylor PhilETaylor - change - 22 Apr 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 22 Apr 2021
avatar PhilETaylor
PhilETaylor - comment - 22 Apr 2021

This also effects the Template manager because in TemplateModel.php there is another is_writable

Screenshot 2021-04-22 at 17 57 10

avatar brianteeman
brianteeman - comment - 22 Apr 2021
avatar PhilETaylor
PhilETaylor - comment - 22 Apr 2021

56 occurrences of is_writable to manually review... to ensure each use is FTP Aware...

Screenshot 2021-04-22 at 18 07 20

avatar brianteeman
brianteeman - comment - 22 Apr 2021

Dont waste your time

avatar PhilETaylor
PhilETaylor - comment - 22 Apr 2021

Im documenting the issues ... that's all... then no one can say it was not tested...

Easier to make a decision based on facts then... although good decisions are slow it seems...

avatar brianteeman
brianteeman - comment - 22 Apr 2021

@PhilETaylor before you go any further can you see if any of this is possible in J3. I don't believe it is as it failed when I tried. If that is correct then its even more of a waste of time to implement something in J4 if no one is currently using it

avatar PhilETaylor
PhilETaylor - comment - 22 Apr 2021

that was my plan after food later :)

avatar richard67
richard67 - comment - 22 Apr 2021

I've put the FTP layer on the agenda for our JBS meeting tomorrow, and maybe our team lead can carry that to the PLT to discuss it there again.

avatar brianteeman
brianteeman - comment - 22 Apr 2021

So another month delay then :(

avatar richard67
richard67 - comment - 22 Apr 2021

I want the opposite, I want to speed up decision and not cause another delay.

avatar richard67
richard67 - comment - 22 Apr 2021

I.e. nobody should wait for that. But we should soon re-evaluate if we really need to keep the FTP layer and drop it if we can.

avatar brianteeman
brianteeman - comment - 22 Apr 2021

We have to wait. If the decision is to remove it then why waste time fixing something no one uses

avatar brianteeman
brianteeman - comment - 22 Apr 2021

and its been on the release blocker list for 3 years

avatar PhilETaylor PhilETaylor - change - 30 Apr 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-04-30 10:37:09
Closed_By PhilETaylor
avatar PhilETaylor PhilETaylor - close - 30 Apr 2021
avatar PhilETaylor
PhilETaylor - comment - 30 Apr 2021

Following the projects decision to remove the FTP Layer from Joomla 4 - this can now be closed.

Add a Comment

Login with GitHub to post a comment