User tests: Successful: Unsuccessful:
Pull Request for Issue #.
Added description for form fields
plugins\captcha\recaptcha\recaptcha.xml
and see the changes
No
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Language & Strings Front End Plugins |
Title |
|
What shall the new field be good for if it has only one option value "2.0"? If it shall be for information only, it doesn't need a dropdown.
This serves no purpose
There are two variants in version 2, invisible and tickbox.
Added description
yes but always version 2, not 3.
There are two variants in version 2, invisible and tickbox.
Thats why there are two different plugins
Here, the version is unconditionally set as auto which makes this new field redundant.
This is irrelevant to the google version, it is part of the Joomla API and for local hosted assets it generates a ?some-hash
so the assets could be correctly invalidated on updates.
There are two variants in version 2, invisible and tickbox.
Thats why there are two different plugins
Exactly, and that's good because we can use the one here and the other one there. If we had only one plugin and made all adjustments in that one plugin, it would be the same everywhere, and we could not chose to show e.g. an invisible captcha on this page and a visible on on another page.
Labels |
Added:
?
?
|
The only thing that could possibly be changed would be the plugin description.
Title |
|
Title |
|
As stated before this is simply wrong.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-21 21:38:06 |
Closed_By | ⇒ | rjharishabh |
The descriptions work fine.
However, you've added a new
version
field in reCaptcha invisible but this field hasn't been used anywhere in recaptcha_invisible.phpHere, the version is unconditionally set as
auto
which makes this new field redundant.joomla-cms/plugins/captcha/recaptcha_invisible/recaptcha_invisible.php
Line 71 in 697a331
Please correct me if I'm wrong here but I couldn't find a single occurrence of
$this->params->get('version'
in recaptcha_invisible.php which means that the new field isn't getting used anywhereI believe your motivation behind adding this field was because it was present in reCaptcha but here it was also being used to render the captcha and load the script as per the version selected
joomla-cms/plugins/captcha/recaptcha/recaptcha.php
Line 68 in 697a331
joomla-cms/plugins/captcha/recaptcha/recaptcha.php
Line 145 in 697a331