? ? Pending

User tests: Successful: Unsuccessful:

avatar rjharishabh
rjharishabh
20 Apr 2021

Pull Request for Issue #.

Summary of Changes

Added description for form fields

  • plugins\captcha\recaptcha\recaptcha.xml

Testing Instructions

  • Open plugin reCaptcha in the backend

and see the changes

Actual result BEFORE applying this Pull Request

recaptcha-before

Expected result AFTER applying this Pull Request

recaptcha-after

Documentation Changes Required

No

avatar rjharishabh rjharishabh - open - 20 Apr 2021
avatar rjharishabh rjharishabh - change - 20 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Apr 2021
Category Administration Language & Strings Front End Plugins
avatar rjharishabh rjharishabh - change - 20 Apr 2021
Title
added version in Invisible reCaptcha and description in reCaptcha
[4.0] added version in Invisible reCaptcha and description in reCaptcha
avatar rjharishabh rjharishabh - edited - 20 Apr 2021
avatar YatharthVyas
YatharthVyas - comment - 20 Apr 2021

The descriptions work fine.
However, you've added a new version field in reCaptcha invisible but this field hasn't been used anywhere in recaptcha_invisible.php

Here, the version is unconditionally set as auto which makes this new field redundant.

array('version' => 'auto', 'relative' => true),

Please correct me if I'm wrong here but I couldn't find a single occurrence of $this->params->get('version' in recaptcha_invisible.php which means that the new field isn't getting used anywhere

I believe your motivation behind adding this field was because it was present in reCaptcha but here it was also being used to render the captcha and load the script as per the version selected

if ($this->params->get('version', '1.0') === '1.0')

avatar richard67
richard67 - comment - 20 Apr 2021

What shall the new field be good for if it has only one option value "2.0"? If it shall be for information only, it doesn't need a dropdown.

avatar brianteeman
brianteeman - comment - 20 Apr 2021

This serves no purpose

avatar rjharishabh
rjharishabh - comment - 20 Apr 2021

There are two variants in version 2, invisible and tickbox.
Added description

avatar richard67
richard67 - comment - 20 Apr 2021

yes but always version 2, not 3.

avatar brianteeman
brianteeman - comment - 20 Apr 2021

There are two variants in version 2, invisible and tickbox.

Thats why there are two different plugins

avatar dgrammatiko
dgrammatiko - comment - 20 Apr 2021

Here, the version is unconditionally set as auto which makes this new field redundant.

This is irrelevant to the google version, it is part of the Joomla API and for local hosted assets it generates a ?some-hash so the assets could be correctly invalidated on updates.

avatar richard67
richard67 - comment - 20 Apr 2021

There are two variants in version 2, invisible and tickbox.

Thats why there are two different plugins

Exactly, and that's good because we can use the one here and the other one there. If we had only one plugin and made all adjustments in that one plugin, it would be the same everywhere, and we could not chose to show e.g. an invisible captcha on this page and a visible on on another page.

avatar rjharishabh rjharishabh - change - 20 Apr 2021
The description was changed
avatar rjharishabh rjharishabh - edited - 20 Apr 2021
avatar rjharishabh rjharishabh - change - 20 Apr 2021
Labels Added: ? ?
avatar rjharishabh rjharishabh - change - 20 Apr 2021
The description was changed
avatar rjharishabh rjharishabh - edited - 20 Apr 2021
avatar brianteeman
brianteeman - comment - 20 Apr 2021

The only thing that could possibly be changed would be the plugin description.

avatar rjharishabh rjharishabh - change - 21 Apr 2021
The description was changed
avatar rjharishabh rjharishabh - edited - 21 Apr 2021
avatar rjharishabh rjharishabh - change - 21 Apr 2021
Title
[4.0] added version in Invisible reCaptcha and description in reCaptcha
[4.0] added description in Invisible reCaptcha
avatar rjharishabh rjharishabh - edited - 21 Apr 2021
avatar rjharishabh rjharishabh - change - 21 Apr 2021
Title
[4.0] added description in Invisible reCaptcha
[4.0] added description in reCaptcha
avatar rjharishabh rjharishabh - edited - 21 Apr 2021
avatar rjharishabh rjharishabh - change - 21 Apr 2021
The description was changed
avatar rjharishabh rjharishabh - edited - 21 Apr 2021
avatar rjharishabh rjharishabh - change - 21 Apr 2021
The description was changed
avatar rjharishabh rjharishabh - edited - 21 Apr 2021
avatar brianteeman
brianteeman - comment - 21 Apr 2021

As stated before this is simply wrong.

avatar rjharishabh rjharishabh - change - 21 Apr 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-04-21 21:38:06
Closed_By rjharishabh
avatar rjharishabh rjharishabh - close - 21 Apr 2021

Add a Comment

Login with GitHub to post a comment