[#33200] - [4.0] Rename Fields - Subfields plugin to Fields - Subform plugin
- Fixed in Code Base
- 23 Apr 2021
- Medium
- Build: 4.0-dev
- # 33200
- Diff
- joomdonation:rename_subfields_to_subform
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
With PR #32864, @brianteeman made some changes to language files to change subfields plugin to subform plugin. However, the actually plugin code is still uses old name subfields. This PR changes the plugin code to have it completely renamed from subfields to subform
Testing Instructions
- Install Joomla 4 nightly build. Or if you have Joomla 4 installation already, please update that installation to Joomla 4 nightly build
- Access to Content -> Fields, create at least one subfields custom field. For testing purpose, maybe you can create two text custom fields (these fields should have Categories set to None) and one subfields like in the attached screenshot (the subfields could have two text fields in it's Fields setting)
-
List of Fields
-
Subfields settings
-
Create a new article, go to Fields tab and enter data for that subfields custom field for the article
-
Download update package for this PR at https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/33200/downloads/42161/Joomla_4.0.0-beta8-dev+pr.33200-Development-Update_Package.zip , go to System -> Update -> Joomla, install that update package
-
Now, access to Content -> Fields again, confirm that the subfields which you created before is now become subform
-
Edit that subform custom field (before it was subfields), confirm that Type now become Subform (Subform). Also, the Fields setting still same as before
-
Edit the article, go to Fields tab, confirm that the data which you entered for the custom fields before is still there.
-
View the article from frontend (maybe make it featured so that it is displayed at homepage by default) and confirm that the data you entered for the custom fields is being displayed properly
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Postgresql Language & Strings Front End Plugins |
| Labels |
Added:
?
?
|
||
| Category | SQL Administration com_admin Postgresql Language & Strings Front End Plugins | ⇒ | SQL Administration com_admin Postgresql Language & Strings Installation Front End Plugins |
| Category | SQL Administration com_admin Postgresql Language & Strings Front End Plugins Installation | ⇒ | SQL Administration com_admin Postgresql Language & Strings Installation Libraries Front End Plugins |
I updated testing instructions. This PR is now ready for testing. Please help testing it.
Subforms should not be listed in subforms.
Rename/update?
\administrator\components\com_fields\src\Field\SubfieldstypeField.php
@Quy I thought about that before and decided that it is not necessary to change. We have Subform. That Subform contains some fields, so the fields which is used inside that Subform could be called as Subfields.
That field type is used to list all fields which can be used in Subform, so leave the field type as how it was before is OK, I think
| Category | SQL Administration com_admin Postgresql Language & Strings Front End Plugins Installation Libraries | ⇒ | SQL Administration com_admin Postgresql com_fields Language & Strings Installation Libraries Front End Plugins |
So I think Subfields is a better name compare to Subfieldstype and made the change.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33200.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33200.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33200.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-23 07:44:19 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
Several mistakes in SQL found, made a PR. See joomdonation#1 .