? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
18 Apr 2021

Summary of Changes

Add closing </span>.
Remove orphaned </a>.

Testing Instructions

Code review.

avatar Quy Quy - open - 18 Apr 2021
avatar Quy Quy - change - 18 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Apr 2021
Category Layout
avatar ChristineWk ChristineWk - test_item - 18 Apr 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 18 Apr 2021

I have tested this item successfully on 844f564


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33191.

avatar YatharthVyas YatharthVyas - test_item - 18 Apr 2021 - Tested successfully
avatar YatharthVyas
YatharthVyas - comment - 18 Apr 2021

I have tested this item successfully on 844f564


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33191.

avatar Quy Quy - change - 18 Apr 2021
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 18 Apr 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33191.

avatar Quy Quy - change - 18 Apr 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-04-18 18:25:08
Closed_By Quy
Labels Added: ?
avatar Quy Quy - close - 18 Apr 2021
avatar Quy Quy - merge - 18 Apr 2021
avatar Quy
Quy - comment - 18 Apr 2021

Thanks for testing!

avatar brianteeman
brianteeman - comment - 18 Apr 2021

@wuy you really shouldnt merge your own PR. The person merging is the last check that the code is correct and you cant be that check if its your own pr

avatar brianteeman
brianteeman - comment - 18 Apr 2021

oops that should have been @Quy


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33191.

Add a Comment

Login with GitHub to post a comment