? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
18 Apr 2021

replacement for #33155

Code review.

avatar PhilETaylor PhilETaylor - open - 18 Apr 2021
avatar PhilETaylor PhilETaylor - change - 18 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Apr 2021
Category Repository
avatar PhilETaylor PhilETaylor - change - 18 Apr 2021
Title
Correct docblock
[4] Correct docblock in stubGenerator
avatar PhilETaylor PhilETaylor - edited - 18 Apr 2021
avatar richard67
richard67 - comment - 18 Apr 2021

Would a @return void in addition make sense? Or would that be wrong?

avatar PhilETaylor
PhilETaylor - comment - 18 Apr 2021

I wrote this up and deleted it before I submitted... chose not to include the commentary - If you or anyone else can prove that this method actually ever returns anything, then we can documentation for that return, but https://3v4l.org/gPnHd leads me to believe that nothing is ever "returned".

avatar richard67
richard67 - comment - 18 Apr 2021

I wrote this up and deleted it before I submitted... chose not to include the commentary - If you or anyone else can prove that this method actually ever returns anything, then we can documentation for that return, but https://3v4l.org/gPnHd leads me to believe that nothing is ever "returned".

You are right, it never will return anything.

avatar richard67 richard67 - test_item - 18 Apr 2021 - Tested successfully
avatar richard67
richard67 - comment - 18 Apr 2021

I have tested this item successfully on 94b39dd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33184.

avatar wilsonge wilsonge - change - 20 Apr 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-04-20 18:38:30
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 20 Apr 2021
avatar wilsonge wilsonge - merge - 20 Apr 2021

Add a Comment

Login with GitHub to post a comment