Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#33181] - [4.0] Improve success message for when you upload a file to a template

? ? ? Pending

User tests: Successful: Unsuccessful:

avatar particthistle
particthistle
18 Apr 2021

Summary of Changes

Tidying up the message displayed when you upload a file to a template.

  • Changed language string COM_TEMPLATES_FILE_UPLOAD_SUCCESS from "File uploaded." to "File uploaded:"
  • Added space between language string and the file name uploaded

Testing Instructions

Apply the patch.
Upload a new file to a site or administrator template.

Actual result BEFORE applying this Pull Request

Message is compressed.
image

Expected result AFTER applying this Pull Request

Message is spaced and : precedes file name.
image

avatar particthistle particthistle - open - 18 Apr 2021
avatar particthistle particthistle - change - 18 Apr 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Apr 2021
Category ⇒ Administration com_templates Language & Strings
avatar Quy
Quy - comment - 18 Apr 2021

Is it even necessary to display the file name? This is not the case in Media Manager.

avatar particthistle
particthistle - comment - 19 Apr 2021

Necessary: no.
Informative UX feedback: yes.

I'm just correcting the appearance of the message that's already there.

Plus while #33179 is an issue, if they upload a file with an uppercase extension, they're not going to see it in the folder tree and start scratching their head.

Mentioning "This is not the case in the Media Manager" raises another point. In the media manager when you upload a file of the same name, it prompts you if you want to overwrite it or not. The file upload in the Template manager doesn't prompt you to overwrite, it just throws an error saying file already exists.

avatar Quy
Quy - comment - 19 Apr 2021

Let's use sprintf instead.

avatar particthistle particthistle - change - 20 Apr 2021
Labels Added: ? ?
avatar particthistle
particthistle - comment - 20 Apr 2021

Updated to sprintf.

Ready for testing.

avatar himanshu007-creator himanshu007-creator - test_item - 21 Apr 2021 - Tested successfully
avatar himanshu007-creator
himanshu007-creator - comment - 21 Apr 2021

I have tested this item ✅ successfully on c5d1357

Works as mentioned.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33181.

avatar richard67
richard67 - comment - 21 Apr 2021

Failing unit tests in Appveyor and Drone and not related to this PR but to the 4.0-dev branch at the time of the PR's creation. This has been fixed meanwhile in the 4.0-dev branch by PR #33207 .

avatar sandramay0905 sandramay0905 - test_item - 21 Apr 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 21 Apr 2021

I have tested this item ✅ successfully on c5d1357

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33181.

avatar richard67 richard67 - alter_testresult - 21 Apr 2021 - himanshu007-creator: Tested successfully
avatar richard67 richard67 - alter_testresult - 21 Apr 2021 - sandramay0905: Tested successfully
avatar richard67 richard67 - change - 21 Apr 2021
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 21 Apr 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33181.

avatar richard67
richard67 - comment - 21 Apr 2021

Appveyor failure is not related to this PR.

avatar rdeutz rdeutz - close - 21 Apr 2021
avatar rdeutz rdeutz - merge - 21 Apr 2021
avatar rdeutz rdeutz - change - 21 Apr 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-04-21 16:05:49
Closed_By ⇒ rdeutz
Labels Added: ?

Add a Comment

Login with GitHub to post a comment