? ? ? Pending

User tests: Successful: Unsuccessful:

avatar particthistle
particthistle
17 Apr 2021

Pull Request for Issue #31306 (comment)

Summary of Changes

Rename the Basic Authentication and Token Authentication plugins to include Web Services in their plugin name and the plugin title.

Testing Instructions

  • Go to System > Plugins
  • Filter for api-authentication plugin type
  • View the plugin name (loaded from the .sys.ini files), as well as looking at the plugin settings to see the titles (from .ini files)

Actual result BEFORE applying this Pull Request

  • Plugin names will not have web services in them.
  • Plugin title on the plugin settings will not have web services in the title.

Expected result AFTER applying this Pull Request

  • Plugin names will have web services in them.
  • Plugin title on the plugin settings will have web services in the title.
    image

Documentation Changes Required

Not specifically. Web Services documentation is still to be comprehensively written, so when it is it will be incorporated in screen grabs and instructions at that time.

avatar particthistle particthistle - open - 17 Apr 2021
avatar particthistle particthistle - change - 17 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Apr 2021
Category Administration Language & Strings
avatar ChristineWk ChristineWk - test_item - 17 Apr 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 17 Apr 2021

I have tested this item successfully on fc023be


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33174.

avatar YatharthVyas
YatharthVyas - comment - 18 Apr 2021

In #31306 (comment)
The suggested names are:

I think it would be better to name the plugins as:

  • API Authentication - Web Services Basic Auth
  • API Authentication - Web Services Joomla Token Auth

I believe the 'Auth' part is missing in the 2nd Plugin name, could you please confirm if this has been done intentionally or not?

avatar particthistle
particthistle - comment - 18 Apr 2021

@YatharthVyas intentionally.

Previous title was API Authentication - Joomla Token

The extra Auth is redundant IMO, as the Token is what's being configured by the plugin.

avatar YatharthVyas YatharthVyas - test_item - 18 Apr 2021 - Tested successfully
avatar YatharthVyas
YatharthVyas - comment - 18 Apr 2021

I have tested this item successfully on fc023be


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33174.

avatar richard67 richard67 - change - 18 Apr 2021
Status Pending Ready to Commit
Labels Added: ? ?
avatar richard67
richard67 - comment - 18 Apr 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33174.

avatar rdeutz rdeutz - close - 19 Apr 2021
avatar rdeutz rdeutz - merge - 19 Apr 2021
avatar rdeutz rdeutz - change - 19 Apr 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-04-19 06:21:59
Closed_By rdeutz
Labels Added: ?

Add a Comment

Login with GitHub to post a comment