Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#33166] - [4] Remove use of deprecated triggerEvent call

? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
16 Apr 2021

Pull Request for Issue # .

Summary of Changes

Remove use of deprecated triggerEvent call in favour of a Joomla 4 way of dispatching events

Testing Instructions

Load Home Dashboard in Joomla 4 freshly installed. Note the sample plugins are all listed in the Sample data plugin

Actual result BEFORE applying this Pull Request

Load Home Dashboard in Joomla 4 freshly installed. Note the sample plugins are all listed in the Sample data plugin

Expected result AFTER applying this Pull Request

Load Home Dashboard in Joomla 4 freshly installed. Note the sample plugins are all listed in the Sample data plugin

Documentation Changes Required

None. Code review only.

avatar PhilETaylor PhilETaylor - open - 16 Apr 2021
avatar PhilETaylor PhilETaylor - change - 16 Apr 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Apr 2021
Category ⇒ Modules Administration
avatar PhilETaylor PhilETaylor - change - 16 Apr 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 16 Apr 2021
avatar brianteeman brianteeman - test_item - 16 Apr 2021 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 16 Apr 2021

I have tested this item ? unsuccessfully on 098c835

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33166.

avatar brianteeman
brianteeman - comment - 16 Apr 2021

When you have no sampledata plugins enabled then you get this error

Warning: array_filter() expects parameter 1 to be array, null given in C:\htdocs\joomla-cms\administrator\modules\mod_sampledata\mod_sampledata.php on line 15

avatar PhilETaylor
PhilETaylor - comment - 16 Apr 2021

cool I can fix that probably

avatar PhilETaylor PhilETaylor - change - 17 Apr 2021
Labels Added: ?
avatar PhilETaylor
PhilETaylor - comment - 17 Apr 2021

I have fixed this PR so that if all the sampledata plugins are disabled, then the refactoring to remove the deprecated triggerEvent call works as it did previously.

avatar YatharthVyas YatharthVyas - test_item - 18 Apr 2021 - Tested successfully
avatar YatharthVyas
YatharthVyas - comment - 18 Apr 2021

I have tested this item ✅ successfully on 3660973

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33166.

avatar anibalsanchez anibalsanchez - test_item - 23 Apr 2021 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 23 Apr 2021

I have tested this item ✅ successfully on 3660973

Test OK

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33166.

avatar PhilETaylor
PhilETaylor - comment - 23 Apr 2021

Thanks for testing @YatharthVyas @anibalsanchez

avatar Quy Quy - change - 23 Apr 2021
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 23 Apr 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33166.

avatar chmst chmst - change - 23 Apr 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-04-23 18:55:55
Closed_By ⇒ chmst
Labels Added: ?
avatar chmst chmst - close - 23 Apr 2021
avatar chmst chmst - merge - 23 Apr 2021
avatar chmst
chmst - comment - 23 Apr 2021

Thanks!

avatar PhilETaylor
PhilETaylor - comment - 23 Apr 2021

1 done - 350 to go :(

Add a Comment

Login with GitHub to post a comment