?
avatar sandramay0905
sandramay0905
16 Apr 2021

What needs to be fixed

  • Install "Blog Sample Data",
  • enable vote-plugin having position Topor Bottom,
  • enable in article options view vote,
  • view menu Blog.
Top Bottom
image image

Why this should be fixed

Both positions should have same padding.

How would you fix it

Don't know.

Side Effects expected

Don't know.

avatar sandramay0905 sandramay0905 - open - 16 Apr 2021
avatar joomla-cms-bot joomla-cms-bot - change - 16 Apr 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 16 Apr 2021
avatar ChristineWk
ChristineWk - comment - 16 Apr 2021

If correct, I don't know, but temporary got spaces with:

div.content_rating img {
padding: 0.1rem;
}


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33164.
avatar sandewt
sandewt - comment - 23 Apr 2021

Related to:

#32919 | [4.0] css changes in voting plugin
#32914 | [4.0] Pagination set to bottom after voting


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33164.

avatar sandewt
sandewt - comment - 23 Apr 2021

See line 84 file: ...\plugins\content\vote\tmpl\rating.php

Now
<div class="content_rating" role="img" aria-label="<?php echo Text::sprintf('PLG_VOTE_STAR_RATING', $rating); ?>">

Add the classitem-content

<div class="item-content content_rating" role="img" aria-label="<?php echo Text::sprintf('PLG_VOTE_STAR_RATING', $rating); ?>">


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33164.

avatar sandramay0905 sandramay0905 - change - 25 Apr 2021
Title
[4.0] Blog-View: Does Vote-Stars need more space?
[4.0] Blog-View: Vote-Stars need padding
avatar sandramay0905 sandramay0905 - edited - 25 Apr 2021
avatar sandramay0905 sandramay0905 - change - 25 Apr 2021
The description was changed
avatar sandramay0905 sandramay0905 - edited - 25 Apr 2021
avatar sandramay0905
sandramay0905 - comment - 26 Apr 2021

@sandewt can you please add #33337 to" in #33164 (comment) as its also about vote if i understand your comment correct.

avatar sandewt
sandewt - comment - 26 Apr 2021

See line 84 file: ...\plugins\content\vote\tmpl\rating.php

@sandramay0905

Oops, my suggestion does NOT work in the position: TOP
This results in two paddings.

issue-vote

avatar rjharishabh
rjharishabh - comment - 26 Apr 2021

I am not able to reproduce this issue.
Don't know what I am missing?

avatar rjharishabh
rjharishabh - comment - 26 Apr 2021

Please test #33340 with both scenarios #33164 and #33337.
Let me know from you.

avatar sandewt
sandewt - comment - 26 Apr 2021

I am not able to reproduce this issue.
Don't know what I am missing?

Empty your browser cache

avatar sandramay0905
sandramay0905 - comment - 26 Apr 2021

@rjharishabh pull request #33340 didn't solve this issue.

avatar sandewt
sandewt - comment - 26 Apr 2021

I am not able to reproduce this issue.
Don't know what I am missing?

Oops I understand you, I am showing here that my proposal above does not work.

avatar rjharishabh
rjharishabh - comment - 26 Apr 2021

I am getting this.

voting

avatar sandewt
sandewt - comment - 26 Apr 2021

I am getting this.

True, but it doesn't work on top

avatar rjharishabh
rjharishabh - comment - 26 Apr 2021

on top

top vote

avatar sandramay0905
sandramay0905 - comment - 26 Apr 2021

@rjharishabh please look at blog-view, not article-view.

avatar rjharishabh
rjharishabh - comment - 26 Apr 2021

@sandramay0905
Can you share the page URL?

avatar sandramay0905
sandramay0905 - comment - 26 Apr 2021

Sure, its the blog-menu of sample data: https://sandramay09051.joomla.com/en/blog.html (terminated)

avatar sandewt
sandewt - comment - 26 Apr 2021

File line 95 - ... : \components\com_content\tmpl\category\blog_item.php

Move the div tag.

Change this

</div>

<?php // Content is generated by content plugin event "onContentAfterDisplay" ?>
<?php echo $this->item->event->afterDisplayContent; ?>

To

<?php // Content is generated by content plugin event "onContentAfterDisplay" ?>
<?php echo $this->item->event->afterDisplayContent; ?>

</div>

I don't know if this change works fine everywhere.

avatar sandewt
sandewt - comment - 30 Apr 2021

@sandramay0905 please test #33426

avatar sandramay0905 sandramay0905 - close - 30 Apr 2021
avatar sandramay0905
sandramay0905 - comment - 30 Apr 2021

Close because of pull request #33426

avatar sandramay0905 sandramay0905 - change - 30 Apr 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-04-30 13:37:41
Closed_By sandramay0905

Add a Comment

Login with GitHub to post a comment