Feeling Lucky
?
?
[#33155] - [4] Correct return type as CLI Application has no menu.
- Closed
- 18 Apr 2021
- Medium
- Build: 4.0-dev
- # 33155
- Diff
- PhilETaylor:patch-126
User tests: Successful: Unsuccessful:
code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository |
particthistle
- comment
- 17 Apr 2021
I have tested this item
Code review change only.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33155.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-18 12:11:10 |
| Closed_By | ⇒ | PhilETaylor | |
| Labels |
Added:
?
?
|
||
PhilETaylor
- comment
- 18 Apr 2021
I’m mobile (actually in bed) - this PR is stupid. It should throw not return in the doc. I closed it because it’s blatantly wrong (yet passed two human tests!) I’ll replace it when at a desk.
Sent from my iPhone
On 18 Apr 2021, at 13:17, Richard Fath @.***> wrote:
@richard67 commented on this pull request.In build/stubGenerator.php:
@@ -116,7 +116,7 @@ public function getName()
- @param string $name The application name for the menu
- @param array $options An array of options to initialise the menu with
- @return \Joomla\CMS\Menu\AbstractMenu|null An AbstractMenu object or null if not set.
- @return \BadMethodCallException Exception thrown as CLI Application has no menu.
I haven't called anything "stupid", and I always consider the possibility that I might be wrong, and it was not my intention to make you close this PR.—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
richard67
- comment
- 18 Apr 2021
Thanks in advance.
I have tested this item✅ successfully on ff62a18
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33155.