? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
15 Apr 2021

Summary of Changes

The CLI command for checking for updates doesn't currently report if it actually found any updates to apply!

This PR changes the output so that it tells you if updates were found.

Testing Instructions

Run the command with and without old version of a Joomla 4 compatible plugin installed that has updates available.

php cli/joomla.php update:extensions:check

Actual result BEFORE applying this Pull Request

Same message regardless of the number of updates found or not found

Screenshot 2021-04-15 at 22 06 38

Expected result AFTER applying this Pull Request

Different output if updates are found (its not currently within this command to actually tell you what they are... that can come later)

Screenshot 2021-04-15 at 22 07 51

Documentation Changes Required

avatar PhilETaylor PhilETaylor - open - 15 Apr 2021
avatar PhilETaylor PhilETaylor - change - 15 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Apr 2021
Category Libraries
avatar PhilETaylor PhilETaylor - change - 15 Apr 2021
Title
show result of checking for updates in CLI
[4] show result of checking for updates in CLI
avatar PhilETaylor PhilETaylor - edited - 15 Apr 2021
avatar alikon alikon - test_item - 16 Apr 2021 - Tested successfully
avatar alikon
alikon - comment - 16 Apr 2021

I have tested this item successfully on ca81f88


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33153.

avatar richard67 richard67 - change - 16 Apr 2021
Labels Added: ?
avatar richard67
richard67 - comment - 16 Apr 2021

@PhilETaylor I've allowed myself to fix the PHP CS error for you.

avatar richard67 richard67 - alter_testresult - 16 Apr 2021 - alikon: Tested successfully
avatar richard67
richard67 - comment - 16 Apr 2021

I've restored the previous test result in the issue tracker since the commit which invalidated it was just a code style change.

avatar richard67 richard67 - alter_testresult - 16 Apr 2021 - alikon: Tested successfully
avatar particthistle particthistle - test_item - 17 Apr 2021 - Tested successfully
avatar particthistle
particthistle - comment - 17 Apr 2021

I have tested this item successfully on 9f46bed

Test results in CLI matched the expected result.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33153.

avatar richard67 richard67 - change - 17 Apr 2021
The description was changed
Status Pending Ready to Commit
avatar richard67 richard67 - edited - 17 Apr 2021
avatar richard67
richard67 - comment - 17 Apr 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33153.

avatar rdeutz rdeutz - change - 19 Apr 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-04-19 06:25:51
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 19 Apr 2021
avatar rdeutz rdeutz - merge - 19 Apr 2021

Add a Comment

Login with GitHub to post a comment