User tests: Successful: Unsuccessful:
Pull Request for Issue #32966
Implements the session handler as a service in the CLI to fix issues when touching the session with CLI commands such as user:delete
php cli/joomla.php user:add
test
test
test@example.xom
6
php cli/joomla.php user:delete
test
yes
Bug 1:
The "session.handler" service has not been created, make sure you have created the "session" service first.
Bug 2:
The Delete users
in yellow appears AFTER you have entered a username when it should be the first thing shown after typing the command like it is when you add a user.
Full context, first adding, then deleting a user:
User is deleted.
No red errors about the session
None
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
Ensure error reporting is set to development in global config. Sorry.
ahh my bad ... i've missed some merge in my test fork
I have tested this item
I have tested this item
Session Handler error disappears and expected behaviour occurs when patch applied.
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-19 06:24:53 |
Closed_By | ⇒ | rdeutz | |
Labels |
Added:
?
?
|
This looks really wrong - sorry I just found this PR courtesy of the cleanup in #33986 - missed it originally. We should not be starting user sessions in the CLI - if something needed fixing because data was stored in the session it's a sign bigger things were wrong. RuntimeStorage is 100% the correct thing for the CLI - not the JoomlaStorage
RuntimeStorage is 100% the correct thing for the CLI - not the JoomlaStorage
Then this is not the PR to be complaining about - go hunt the place recently where someone changed the CLI storage.. .this PR just fixed their mess :)
This PR did change the CLI storage - you've changed it from Runtime to Joomla in this PR :)
Hmmmm....
unable to replicate the issue when

php cli/joomla.php user:delete
without this pr