? ? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
14 Apr 2021

Pull Request for Issue #31649.

Summary of Changes

There was a typo in allowEdit method of Field controller makes user is not allowed to edit his own custom field if he has Edit Own permission but not Edit permission. This PR fixes that issue

Testing Instructions

  1. Login to administrator area of your site using Super User account
  2. Access to Content -> Fields, then click on Options button in the toolbar, navigate to Permissions tab, select Manager user group:
  • Set Edit permission to Denied
  • Set Edit Own permission to Allowed
  1. Logout, then login to administrator area again using a manager account. Access to Content -> Fields. Create a new custom field, then go back to Fields list screen and click on that field to edit:
  • Before patch: You get get error could not edit field
  • After patch, you can edit field.
avatar joomdonation joomdonation - open - 14 Apr 2021
avatar joomdonation joomdonation - change - 14 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Apr 2021
Category Administration com_fields
avatar sandramay0905 sandramay0905 - test_item - 15 Apr 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 15 Apr 2021

I have tested this item successfully on cc94b2f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33129.

avatar Quy Quy - test_item - 16 Apr 2021 - Tested successfully
avatar Quy
Quy - comment - 16 Apr 2021

I have tested this item successfully on cc94b2f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33129.

avatar Quy Quy - change - 16 Apr 2021
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 16 Apr 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33129.

avatar chmst chmst - change - 22 Apr 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-04-22 06:56:45
Closed_By chmst
Labels Added: ?
avatar chmst chmst - close - 22 Apr 2021
avatar chmst chmst - merge - 22 Apr 2021
avatar chmst
chmst - comment - 22 Apr 2021

Thanks!

Add a Comment

Login with GitHub to post a comment