[#33115] - Delete unnecessary code
- Fixed in Code Base
- 14 Apr 2021
- Medium
- Build: staging
- # 33115
- Diff
- eopws:staging
User tests: Successful: Unsuccessful:
Summary of Changes
Delete extra if block.
This pull request is not assigned with any issue as it makes the code more redable
Testing Instructions
No testing instruction is specified as the pull request doesn't change the application logic, but makes code more readable
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
What makes you think the code isnt required?
Because the code has inner if block with the same condition (!isset($paths[$dispatcherHash][$path])) as the outer if block has (!isset($paths[$dispatcherHash][$path]))
That's exactly the sort of information that should have been in your first post explaining the change. Remember that a diff/patch/ will not always show enough code for it to be obvious
Sory, if I provided not enough information. I thought this pull request has too small changes to write a lot to description.
I have tested this item
Code review. Obviously redundant code after checking line 247 (outer if{})
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33115.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33115.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33115.
| Labels |
Added:
?
?
Removed: ? |
||
Does anybody know how to delete that second commit that I added accidentally?
| Labels |
Removed:
?
|
||
@eopws I've reverted your last commit for you. Maybe one thing you should keep in mind when making again a pull request in future: Please always first create a new branch based on the branch for which the PR shall be made, which is in this case staging, and then use that new branch for the PR. Golden rule: For each PR a separate branch.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-14 18:32:11 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thanks
What makes you think the code isnt required?
Where is it used? That way people will be able to test it.