User tests: Successful: Unsuccessful:
Our configuration for TinyMCE supports the use of an editor.css file located in the template css folder. This allows for the heading levels etc to be displayed correctly in the wysiwyg editor.
It is not simply a case of including the entire template.css as the editor is then loading 13 thousand lines of css most of which is not needed and fills the tinymce toolbar dropdowns with lots and lots of useless fluff
With this latest version of TinyMCE it is possible to import the template.css file and then have a series of rules on what to include and exclude. This would be useful if there were seperate css files for layout and design etc but there aren't and I am of the opinion that this approach is far more work than is needed.
So I have taken the fallback editor.css from the system template and created a cassiopeia version with this PR.
It has to be an scss file for our build tools.
It can not include the fonts used in cassiopeia as they are defined in the template php and not the css.
To test this PR install the blog sample data and go to the typography content item
Apply the PR and run npm ci
or npm run build:css
and compare the typography content item again
Note while this editor.css file may not be absolutely required it serves as a good example to follow for template designers.
The only significant difference in the before and after images is the font size. Making it closer to a wysiwyg editor.
Status | New | ⇒ | Pending |
Category | ⇒ | Front End Templates (site) NPM Change |
Labels |
Added:
NPM Resource Changed
?
|
@sandramay0905 Yes. If you don't want to run npm (or don't have it installed on your system), you can download update package for this PR, update it to your site and test it. The link to the download package is https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/33112/downloads/41855/Joomla_4.0.0-beta8-dev+pr.33112-Development-Update_Package.zip (I think you know it already, just in case you are not familiar with it)
Thanks @joomdonation for the answer. You are right, i know it already but had one pr (i think it was one of brians), where the update package was not enough and npm was the only one to test, so it wasn't clear for me, how the prebuilt packages-thing work.
Beside this i got different test-result using the xml-thing, which i now don't use but at the download-site you can read You can test this package as an update by using this custom update server:
so i'm not certain, if this is true.
@sandramay0905 Both methods worked for me. Here is the screenshot of the article after I updated the package (upload the package manually or using Custom URL)
I have tested this item
Both methods worked for me.
Thanks. My #33112 (comment) was about generally behaviour, not this specific pr.
Can you mark your test as successfully ;-)?
I have tested this item
RTC
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-16 07:31:00 |
Closed_By | ⇒ | rdeutz | |
Labels |
Added:
?
|
@brianteeman can this pr get a test using prebuilt package? sorry, i don't know so i ask before giving a false result for test.