[#33106] - [4.0] Move markup to not display bottom border in sample data list
- Fixed in Code Base
- 14 Apr 2021
- Medium
- Build: 4.0-dev
- # 33106
- Diff
- Quy:33067-sample-data
User tests: Successful: Unsuccessful:
Pull Request for Issue #33067 .
Summary of Changes
After each sample data, there are progress bar/messages in list items and hidden by default.
The last bottom border is from the sample data and technically not the last child, thus it is not hidden.
Move the progress bar/messages into the sample data list item and not make them be list items.
Testing Instructions
Go to Home Dashboard
See no bottom border in Sample Data box.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
The last visible border is not the last child.
It works perfectly
.list-group-item:nth-last-child(3) {
border-bottom: none;
}
If it can be done with less markup without resorting to CSS, then wouldn't that be better?
I am generally not a fan of nested lists
This PR moves the nested list so technically it is the same as before.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33106.
This PR moves the nested list so technically it is the same as before.
It's not but I can't be bothered on such a minor minor issue
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33106.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33106.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-14 08:17:39 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Why not just apply the css that was proposed