[#33102] - [4.0] Cassiopeia unpublished badges
- Fixed in Code Base
- 14 Apr 2021
- Medium
- Build: 4.0-dev
- # 33102
- Diff
- brianteeman:cassbadge
User tests: Successful: Unsuccessful:
The markup for the Unpublished, Not Published Yet and Expired badges that is displayed in various views on the front end to administrators was incorrect.
Before
After
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact com_content com_tags |
| Labels |
Added:
?
|
||
| Category | Front End com_contact com_content com_tags | ⇒ | Front End com_contact com_content com_newsfeeds com_tags |
Good find. But using "badge bg-warning" without text-colour shlould be sufficient, as the text colour is calculated. So user could choose an own colour scheme where the bg warning is white or light grey.
@chmst I assumed it was there for a reason they just chose the wrong one. I was only interested in fixing a bug and didnt want to be accused of destroying the template design etc. For reference the bg-warning text-light combination also fails contrast checks but it was beyond the scope of this PR
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33102.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33102.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-14 08:19:28 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Thanks for testing and merging
I have tested this item✅ successfully on 67a7da1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33102.