Feeling Lucky
?
[#33090] - [4.0] fix webp support
- Closed
- 2 May 2021
- Medium
- Build: 4.0-dev
- # 33090
- Diff
- brianteeman:webpmedia
User tests: Successful: Unsuccessful:
#31048 added support for webp images however it was not complete. MediaHelper::isImage was not updated to support webp. As a result while webp could be added to media manager as an allowed image format everything worked except for the display of the thumbnail.
As this PR fixes that we might as well add webp to the default list of supported image formats.
To test
- either do a fresh install with the prebuilt package OR apply this pr, run npm ci and go to the media manager options. delete all the values in the Legal Extensions (File Types), Legal Image Extensions (File Types) and Legal MIME Types and then save the options. This will reset the value to the new defaults.
- Try to upload any webp image
- Try to crop and resize the image
- Try to rename the image
- Get a shareable link and make sure it works
Before
After
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media NPM Change Repository SQL Installation Postgresql Libraries |
brianteeman
- comment
- 11 Apr 2021
I didn't test further cause i didn't do the test instructions "do a fresh install with the prebuilt package OR apply this pr, run npm" and i guessed thats why the changes are not saved.
Without following those test instructions it wont work
| Labels |
Added:
NPM Resource Changed
?
|
||
| Category | Administration com_media NPM Change Repository SQL Installation Postgresql Libraries | ⇒ | Administration com_admin SQL Postgresql com_banners com_cache com_categories |
brianteeman
- comment
- 2 May 2021
closed - will make new pr
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-02 08:33:25 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Removed:
NPM Resource Changed
|
||
@brianteeman on a fresh install using launch.joomla.org i did a Upload & Update using a prebuilt package.
Upload of webp-image works, not crop and resize as the changes are not saved.
I didn't test further cause i didn't do the test instructions "do a fresh install with the prebuilt package OR apply this pr, run npm" and i guessed thats why the changes are not saved.
If my guess is wrong i can mark the test as unsuccessfully.