[#33082] - [4.0] Language switcher: improving display of dropdown with flags
- Fixed in Code Base
- 30 Apr 2021
- Medium
- Build: 4.0-dev
- # 33082
- Diff
- infograf768:4.0_switcher_drop_flags
User tests: Successful: Unsuccessful:
Summary of Changes
Adding shadow to dropdown. Normalizing RTL and LTR. Using em instead of px.
Taking off useless Reduce Line Height parameter (as we now use bootstrap).
Correcting arrow distance from dropdown.
Testing Instructions
Install multilingual site with sample data, including Persian language.
I used فارس (Iran) for Persian native content language)
Edit mod_languages settings to:
Display the switcher in frontend
Patch and test.
(Reduce Line Height will not display any more in module params)
Actual result BEFORE applying this Pull Request
LTR
RTL
Expected result AFTER applying this Pull Request
LTR
RTL
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change Language & Strings Modules Front End |
| Labels |
Added:
?
NPM Resource Changed
?
|
||
I have tested this item
All is working fine but the alignment of languages in the dropdown in RTL language. They are aligned to left.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33082.
@pabloarias
Maybe you did not use the correct clean install with patch as I get here OK
I suggest you make a clean install with te pre-built packages:
https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/33082/downloads/41791/
I have tested this item
You are right, after installing the package with Joomla and the PR it works. Thank you!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33082.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33082.
HLeithner
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-30 22:01:13 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 667e695
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33082.