drone not happy => phpcs

I just migrated to PHP 8 - logged in via different browser to create log events. Works OK. On logout I get this:

Joomla\CMS\Application\WebApplication::loadIdentity(): Argument #1 ($identity) must be of type ?Joomla\CMS\User\User, int given, called in /Users/ceford/Sites/j4test/plugins/actionlog/joomla/joomla.php on line 894

Don't know what to make of this!

Personal, I would not include the changes from long array syntax to short array syntax on this PR to avoid potential merge conflicts when merge changes from staging to 4.0-dev. When we really want to make this kind of change, there is tool to allow us to make change through our whole codebase. Also, there is error as reported by @ceford . Could you please look at it?

Should be:

$oldVersion = Text::_('JLIB_UNKNOWN');

and add:

use Joomla\CMS\Language\Text;

I have tested this item ✅ successfully on 3aae819

Tested successfully in Beta8-dev of 16 April using Wampserver 3.2.4 and PHP 8.0.2

I have been doing other stuff so catching up with testing. Working through some of the actions that invoke the actions log plugin, after front end logout I got an error:

 0 Joomla\CMS\Application\WebApplication::loadIdentity(): Argument #1 ($identity) must be of type ?Joomla\CMS\User\User, int given, called in /Users/ceford/Sites/j4test/plugins/actionlog/joomla/joomla.php on line 894 

Stopped testing there. This is using PHP 8

Updated array() to [] syntax

Currently this is against the Joomla Coding Guidelines - please merge joomla/coding-standards#273 ;-)

@HLeithner could you resolve the conflict, please?

This pull request has automatically rebased to 4.2-dev.