User tests: Successful: Unsuccessful:
pr for #31242
This is a temp fix until upstream addresses this onokumus/metismenujs#9
The fix applied is the exact same one used by webaim.org so should be acceptable from an a11y perspective.
There will be no change for most users. It is only if they have reduced motion set in their operating system that they encounter the problem this fixes.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) NPM Change |
Labels |
Added:
NPM Resource Changed
?
|
@HLeithner it would be, but upstream hasnt responded yet at all to the issue report filed by @ciar4n
Yes I have seen this, but also see that this repo never got a pull request^^
@HLeithner one is javascript and one is css. I wouldnt dream of submitting a js pull request.
Not sure what you are trying to prove by blocking this one line pull request
I'm not blocking, just try to prevent to add a TODO
to the code base which maybe is never found again ;-)
But yeah doesn't look good for metismenujs maybe we should remove/replace it because it's unmaintained?
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-08 17:04:08 |
Closed_By | ⇒ | HLeithner |
Maybe a PR upstream would be more useful?