NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
8 Apr 2021

pr for #31242

This is a temp fix until upstream addresses this onokumus/metismenujs#9

The fix applied is the exact same one used by webaim.org so should be acceptable from an a11y perspective.

There will be no change for most users. It is only if they have reduced motion set in their operating system that they encounter the problem this fixes.

avatar brianteeman brianteeman - open - 8 Apr 2021
avatar brianteeman brianteeman - change - 8 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Apr 2021
Category Administration Templates (admin) NPM Change
0459236 8 Apr 2021 avatar brianteeman cs
avatar brianteeman brianteeman - change - 8 Apr 2021
Labels Added: NPM Resource Changed ?
avatar HLeithner
HLeithner - comment - 8 Apr 2021

Maybe a PR upstream would be more useful?

avatar brianteeman
brianteeman - comment - 8 Apr 2021

@HLeithner it would be, but upstream hasnt responded yet at all to the issue report filed by @ciar4n

avatar HLeithner
HLeithner - comment - 8 Apr 2021

Yes I have seen this, but also see that this repo never got a pull request^^

avatar brianteeman
brianteeman - comment - 8 Apr 2021

@HLeithner one is javascript and one is css. I wouldnt dream of submitting a js pull request.

Not sure what you are trying to prove by blocking this one line pull request

avatar HLeithner
HLeithner - comment - 8 Apr 2021

I'm not blocking, just try to prevent to add a TODO to the code base which maybe is never found again ;-)

But yeah doesn't look good for metismenujs maybe we should remove/replace it because it's unmaintained?

avatar HLeithner HLeithner - close - 8 Apr 2021
avatar HLeithner HLeithner - merge - 8 Apr 2021
avatar HLeithner HLeithner - change - 8 Apr 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-04-08 17:04:08
Closed_By HLeithner

Add a Comment

Login with GitHub to post a comment