User tests: Successful: Unsuccessful:
Pull Request for Issue #33047
As title says
Log in frontend and hover the article (or contact) edit icon.
LTR
RTL
Status | New | ⇒ | Pending |
Category | ⇒ | Front End Templates (site) NPM Change |
I have tested this item
Don't know if I should raise this here, but:
on LTR the menu item edit icons have an ordinary floating title rather than a Tooltip
on RTL the Breadcrumbs edit Tooltip appears at the right
I thought these titles/tooltips were something to be avoided for accessibiity reasons - or is it ok on buttons and links?
We were just looking at this in a tutorial session with GSoC students and noticed some things:
Folks, this patch only deals with the placement of the Edit tooltip for article and contact.
It is unrelated to frontend menu items or modules edit tips (including the breadcrumbs module).
Changes made in #32757 took "Edit" off the module buttons... should the "Edit" also be taken off the link on the articles?
The main reason to take off the term "Edit" from modules button was I guess the limited space. Also these edit buttons are never used by simple authors/editors but only those with $user->authorise('module.edit.frontend'
which should know what they do (default is super users).
For these I suggest you open different issues.
Status | Pending | ⇒ | Ready to Commit |
rtc
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-09 16:47:33 |
Closed_By | ⇒ | richard67 | |
Labels |
Added:
NPM Resource Changed
?
?
|
Thanks!
I have tested this item✅ successfully on 0eca932
Tested:
LTR and RTL
Edit article and edit (single) contact
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33066.