NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
8 Apr 2021

Pull Request for Issue #33047

Summary of Changes

As title says

Testing Instructions

Log in frontend and hover the article (or contact) edit icon.

Actual result BEFORE applying this Pull Request

tooltip-edit-button

Expected result AFTER applying this Pull Request

LTR

Screen Shot 2021-04-08 at 06 55 41

RTL

Screen Shot 2021-04-07 at 12 08 50

Documentation Changes Required

avatar infograf768 infograf768 - open - 8 Apr 2021
avatar infograf768 infograf768 - change - 8 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Apr 2021
Category Front End Templates (site) NPM Change
avatar sandewt sandewt - test_item - 8 Apr 2021 - Tested successfully
avatar sandewt
sandewt - comment - 8 Apr 2021

I have tested this item successfully on 0eca932

Tested:

LTR and RTL
Edit article and edit (single) contact


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33066.

avatar ceford ceford - test_item - 8 Apr 2021 - Tested successfully
avatar ceford
ceford - comment - 8 Apr 2021

I have tested this item successfully on 0eca932

Don't know if I should raise this here, but:
on LTR the menu item edit icons have an ordinary floating title rather than a Tooltip
on RTL the Breadcrumbs edit Tooltip appears at the right
I thought these titles/tooltips were something to be avoided for accessibiity reasons - or is it ok on buttons and links?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33066.

avatar particthistle
particthistle - comment - 8 Apr 2021

We were just looking at this in a tutorial session with GSoC students and noticed some things:

  • Tooltip only applies at the moment to the icon and not the word "Edit" when you hover - should it be on both?
  • Changes made in #32757 took "Edit" off the module buttons... should the "Edit" also be taken off the link on the articles?
  • The tooltip currently only shows "Publish Article" (or the state of the article if it's something else). Should it also add "Edit" to the tool tip so that the tip is instructional and not just informational?
avatar infograf768
infograf768 - comment - 8 Apr 2021

Folks, this patch only deals with the placement of the Edit tooltip for article and contact.
It is unrelated to frontend menu items or modules edit tips (including the breadcrumbs module).

Changes made in #32757 took "Edit" off the module buttons... should the "Edit" also be taken off the link on the articles?

The main reason to take off the term "Edit" from modules button was I guess the limited space. Also these edit buttons are never used by simple authors/editors but only those with $user->authorise('module.edit.frontend' which should know what they do (default is super users).

For these I suggest you open different issues.

avatar infograf768 infograf768 - change - 8 Apr 2021
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 8 Apr 2021

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33066.

avatar richard67 richard67 - change - 9 Apr 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-04-09 16:47:33
Closed_By richard67
Labels Added: NPM Resource Changed ? ?
avatar richard67 richard67 - close - 9 Apr 2021
avatar richard67 richard67 - merge - 9 Apr 2021
avatar richard67
richard67 - comment - 9 Apr 2021

Thanks!

Add a Comment

Login with GitHub to post a comment