? ? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
7 Apr 2021

Pull Request for Issue #33056

Summary of Changes

Provide feedback for a legitimate gotcha.

Admin A should not be able to add authenticators for user B.

Testing Instructions

Login as Admin A on a https:// site.

Edit User B with intention of adding an authenticators

Actual result BEFORE applying this Pull Request

No button to add an authenticator
No feedback why
Confusion as evidenced in #33056

Expected result AFTER applying this Pull Request

Screenshot 2021-04-07 at 23 50 01

Documentation Changes Required

None.

// @nikosdion might be able to provide the link to the exact reason he added this reasonable requirement, IIRC it was a WebAuthn standard thing? I might remember wrong.

// @Dr-Sommer for testing.

// @brianteeman to make my English Joomlafied.

avatar PhilETaylor PhilETaylor - open - 7 Apr 2021
avatar PhilETaylor PhilETaylor - change - 7 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Apr 2021
Category Administration Language & Strings Layout
avatar richard67
richard67 - comment - 7 Apr 2021

Can issue #33056 be closed because this PR here solves it completely? Or is there something remaining so it should stay open?

avatar PhilETaylor
PhilETaylor - comment - 7 Apr 2021

Please close it. there is nothing left

avatar PhilETaylor PhilETaylor - change - 16 Apr 2021
Labels Added: ? ?
avatar Quy Quy - test_item - 16 Apr 2021 - Tested successfully
avatar Quy
Quy - comment - 16 Apr 2021

I have tested this item successfully on c6dd686


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33064.

avatar particthistle particthistle - test_item - 17 Apr 2021 - Tested successfully
avatar particthistle
particthistle - comment - 17 Apr 2021

I have tested this item successfully on c6dd686

Displays error message when it's not the logged in user's settings being viewed.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33064.

avatar richard67 richard67 - change - 17 Apr 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 17 Apr 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33064.

avatar rdeutz rdeutz - change - 19 Apr 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-04-19 06:24:11
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 19 Apr 2021
avatar rdeutz rdeutz - merge - 19 Apr 2021

Add a Comment

Login with GitHub to post a comment