? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
7 Apr 2021

Pull Request for Issue #33017

Steps to reproduce the issue

Go to the Administrator login page. At the bottom left there is a link to Joomla! News - try it.

Expected result

Joomla news page

Actual result

Joomla main page

Screenshot 2021-04-07 at 22 47 08

avatar PhilETaylor PhilETaylor - open - 7 Apr 2021
avatar PhilETaylor PhilETaylor - change - 7 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Apr 2021
Category Modules Administration
avatar PhilETaylor PhilETaylor - change - 7 Apr 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 7 Apr 2021
avatar Quy
Quy - comment - 7 Apr 2021

Please update the SQL files.

avatar ceford ceford - test_item - 8 Apr 2021 - Tested successfully
avatar ceford
ceford - comment - 8 Apr 2021

I have tested this item successfully on 37e7d2f

Note for testers: apply the patch; then go to the Login Support Information (Admin) module and clear the News URL field. Save and it is repopulated with the new default url. Save again. Then logout and check the Joomla News URL on the Login page.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33058.

avatar PhilETaylor PhilETaylor - change - 8 Apr 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 8 Apr 2021
Category Modules Administration SQL Administration com_admin Postgresql Modules Installation
avatar PhilETaylor
PhilETaylor - comment - 8 Apr 2021

Links now updated in the SQL files.

avatar ceford ceford - test_item - 8 Apr 2021 - Tested successfully
avatar ceford
ceford - comment - 8 Apr 2021

I have tested this item successfully on f4bbeb5

Am I right in thinking the sql changes are for new installations? Existing installations need to clear the newsurl field and save to restore the new default. Just wondering where/if to document that. Someone is bound to notice the problem and report it again.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33058.

avatar PhilETaylor
PhilETaylor - comment - 8 Apr 2021

Joomla 4 "has not been released" so all installs will be "new installs" :-)

avatar richard67
richard67 - comment - 8 Apr 2021

Joomla 4 "has not been released" so all installs will be "new installs" :-)

That's not right. We grant that people can update from 4.0 Beta versions beginning with 1 to later Beta or RC and stable versions.

avatar richard67
richard67 - comment - 8 Apr 2021

P.S.: Here in this PR an existing update SQL script (per db type) is modified, that's correct and needed when updating older versions.

Theoretically it would need also a new update SQL with a new date in file name so it runs when updating last Beta to next Beta which will include this PR, with "UPDATE" statements for changing the params (which is a varchar in database, not a json type, but contains json).

Practically we sometimes decide not to do that when it's risky to modify json params with "REPLACE" SQL statements.

Here it would not be risky because we could do an exact string match, so we replace "news_url":"https://www.joomla.org/" by "news_url":"https://www.joomla.org/announcements.html". The search sting and the replace string have to cover the complete name and value pair of the json, including the double quotes, so we can be sure we don't replace other, similar parameter values.

The "WHERE" clause for such a replace statement should make sure that we only find relevant records

WHERE `module` = 'mod_loginsupport' AND `client_id` = 1 AND `params` LIKE '%"news_url":"https://www.joomla.org/"%'
avatar Quy Quy - test_item - 15 Apr 2021 - Tested successfully
avatar Quy
Quy - comment - 15 Apr 2021

I have tested this item successfully on f4bbeb5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33058.

avatar richard67 richard67 - change - 15 Apr 2021
The description was changed
Status Pending Ready to Commit
avatar richard67 richard67 - edited - 15 Apr 2021
avatar richard67
richard67 - comment - 15 Apr 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33058.

avatar rdeutz rdeutz - change - 16 Apr 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-04-16 07:29:17
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 16 Apr 2021
avatar rdeutz rdeutz - merge - 16 Apr 2021

Add a Comment

Login with GitHub to post a comment