User tests: Successful: Unsuccessful:
Pull Request for Issue #33017
Go to the Administrator login page. At the bottom left there is a link to Joomla! News - try it.
Joomla news page
Joomla main page
Status | New | ⇒ | Pending |
Category | ⇒ | Modules Administration |
I have tested this item
Note for testers: apply the patch; then go to the Login Support Information (Admin) module and clear the News URL field. Save and it is repopulated with the new default url. Save again. Then logout and check the Joomla News URL on the Login page.
Labels |
Added:
?
|
Category | Modules Administration | ⇒ | SQL Administration com_admin Postgresql Modules Installation |
Links now updated in the SQL files.
I have tested this item
Am I right in thinking the sql changes are for new installations? Existing installations need to clear the newsurl field and save to restore the new default. Just wondering where/if to document that. Someone is bound to notice the problem and report it again.
Joomla 4 "has not been released" so all installs will be "new installs" :-)
Joomla 4 "has not been released" so all installs will be "new installs" :-)
That's not right. We grant that people can update from 4.0 Beta versions beginning with 1 to later Beta or RC and stable versions.
P.S.: Here in this PR an existing update SQL script (per db type) is modified, that's correct and needed when updating older versions.
Theoretically it would need also a new update SQL with a new date in file name so it runs when updating last Beta to next Beta which will include this PR, with "UPDATE" statements for changing the params (which is a varchar in database, not a json type, but contains json).
Practically we sometimes decide not to do that when it's risky to modify json params with "REPLACE" SQL statements.
Here it would not be risky because we could do an exact string match, so we replace "news_url":"https://www.joomla.org/"
by "news_url":"https://www.joomla.org/announcements.html"
. The search sting and the replace string have to cover the complete name and value pair of the json, including the double quotes, so we can be sure we don't replace other, similar parameter values.
The "WHERE" clause for such a replace statement should make sure that we only find relevant records
WHERE `module` = 'mod_loginsupport' AND `client_id` = 1 AND `params` LIKE '%"news_url":"https://www.joomla.org/"%'
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-16 07:29:17 |
Closed_By | ⇒ | rdeutz | |
Labels |
Added:
?
|
Please update the SQL files.