[#33055] - [4] Catch, translate, and expound when GD not available.
- Fixed in Code Base
- 2 May 2021
- Medium
- Build: 4.0-dev
- # 33055
- Diff
- PhilETaylor:gdnotavailable
User tests: Successful: Unsuccessful:
Summary of Changes
A more user friendly error message instead of an unhandled PHP exception.
Testing Instructions
Install Joomla 4 on a server with GD not installed or not enabled.
Go to Joomla 4 admin -> Templates/Site Templates -> Cassiopeia Details and Files -> Click template_thumbnail.png in left menu
Actual result BEFORE applying this Pull Request
without debug:
With debug:
Expected result AFTER applying this Pull Request
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates Language & Strings |
Im unable to generate a GD message in Media Manager...
I am assuming that GD is being used for the crop and rotate functionality in the template. The same functionality is present in the media manager although if memory serves me correctly the implementation is different (it shouldnt be)
yeah most of the image manipulation is using GD functions... Im going to rebuild a new docker container without GD and see what I can break.
I am assuming that GD is being used for the crop and rotate functionality in the template
Nope!
Crop & resize certainly DO work without GD... It looks like they use cropperjs 1.5.11 https://fengyuanchen.github.io/cropperjs
This PR is ready for testing.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33055.
| Labels |
Added:
?
?
|
||
I've restored the previous test result since the commit which invalidated the test was just a code style change.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33055.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33055.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-02 19:34:50 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
|
||
Thanks!
Doesnt this error also happen in media manager? It should. In which case it should be a generic mesage and not a com_template message