[#33045] - [4.0] Admin modules bootstrap
- Fixed in Code Base
- 23 Apr 2021
- Medium
- Build: 4.0-dev
- # 33045
- Diff
- brianteeman:admin_modules
User tests: Successful: Unsuccessful:
Re-implements the missing code to output the bootstrap size and header tag for the admin modules.
At this time to test you will need to do a full install as there is NO update script yet (@richard67 can you assist on that please)
There will be no visible difference but if you edit an admin module then you can change the bootstrap size and the header tag in the advanced tab of any admin module and it will have an effect. Before this pr they didnt do anything at all.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) SQL Installation Postgresql |
I dont care. I dont even care if there is an update mechanism as nothing will break (i think)
This PR does what it says but see #25952 (comment)
Default bs 12 displays the modules full width of the column, other bs will just reduce the width of the module inside that column width.
Example bs6 gives for Site
Yes that is correct because on that page there is a two column grid. So bs6 is half the width of the column.
If you go to the help page then that page has three columns etc.
Changing the fr columns is beyond the scope of this PR.
I have tested this item
I've tested this issue successfully.
Now there are other issues, for example: with the 2 columns layout, as @infograf768 says, it's not intuitive.
Another example is that if I choose width of 6 for 2 modules, they should be in the same row, not one on top of the other.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33045.
@brianteeman can your pull request get a test or need before resolve conflicting files?
| Labels |
Added:
Conflicting Files
?
|
||
conflicts resolved
@brianteeman I will test when launch.joomla.org will work again, see joomla/joomla-websites#1614 (comment).
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33045.
choose width of 6 for 2 modules, they should be in the same row, not one on top of the other.
@pabloarias correct but i guess its not in the scope of this pull request so you need to open a new issue.
Can you please retest? Since your test are new commits and your test doesn't count.
I have tested this item
Tested again. Thank you!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33045.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33045.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-23 09:29:23 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
Removed: Conflicting Files |
||
thanks
@brianteeman Could you test PR #33370 for the SQL updates related to this PR? Thanks in advance.
I've got better things to do than test an update from beta to beta. - sorry
At this time to test you will need to do a full install as there is NO update script yet (@richard67 can you assist on that please)
@brianteeman not sure why you ask richard for help but when he help you tell him he is on his own? That's a strange behavior!
I think that was the last time I did help.
Sorry you missed something or I misunderstood something.
I understood your original post as a reminder that we dont change this json data as its userdata
Sorry you missed something or I misunderstood something.
I understood your original post as a reminder that we dont change this json data as its userdata
I missed that it will really need the update SQL because I did not except it to look like reported in issue #33314 without it.
@brianteeman Should we really do that with update SQL scripts for updates? Although it is possible in many cases, some people say we should not modify json with SQL replace statements. If it shall be done with SQL, I can help, but it might be weekend until I have time, and I don’t want to be the one who has to decide if we do it with SQL script or if we use script.php, so other opinions are welcome.