? Pending

User tests: Successful: Unsuccessful:

avatar cric2000
cric2000
6 Apr 2021

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

avatar cric2000 cric2000 - open - 6 Apr 2021
avatar cric2000 cric2000 - change - 6 Apr 2021
Status New Pending
avatar brianteeman
brianteeman - comment - 6 Apr 2021

This is just as invalid as the original markup. The original file is adequate for the purpose it serves. Plus if you look more closely you will find that there are about 50 files that would need to be updated not just this one. Finally when you submitted the pull request you were asked 5 questions that you need to answer.

avatar Fedik
Fedik - comment - 6 Apr 2021

The existing html is pretty valid (if not count empty title tag).
Nothing to fix here.

avatar richard67
richard67 - comment - 6 Apr 2021

@cric2000 First of all thank you for your first pull request. Unfortunately it has a few mistakes:

  1. When you create a new pull request (PR) you can see there are headings like "Summary of Changes", "Testing Instructions". They are not there for nothing. We assume that the creator of the PR adds the corresponding information below these headings. For testing instructions in such a case like here a "Code review" would be sufficient.
  2. The index.html files in some of Joomla's folders are not meant to be shown in a browser. They are dummy files in otherwise empty folders which are needed to create the zip packages, because zip by default doesn't pack empty folders. In past we had these files in all folders in order to prevent directory listing in the browser. But this is not necessary anymore since directory listing is blocked in every reasonable webserver configuration. So these files don't require things like "normal" html pages should contain.
  3. As @Fedik pointed out, the html syntax of these files is already valid. Maybe you have adjusted the validator for the wrong kind of html version so it has complained.

I hope you understand now why I close this PR.

Please don't be disappointed. It can happen even to experienced contributors that we make wrong PR's.

The next one will be better ?

avatar richard67 richard67 - close - 6 Apr 2021
avatar richard67 richard67 - change - 6 Apr 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-04-06 08:22:21
Closed_By richard67
Labels Added: ?

Add a Comment

Login with GitHub to post a comment