[#33025] - [4.0] JText error message
- Fixed in Code Base
- 6 Apr 2021
- Medium
- Build: 4.0-dev
- # 33025
- Diff
- brianteeman:jtext
User tests: Successful: Unsuccessful:
Make sure we use the namespaced Text:: instead of JText::
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_languages |
| Labels |
Added:
?
|
||
| Category | Administration com_languages | ⇒ | Administration com_languages com_modules |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33025.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33025.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33025.
Sorry i have no clue how to do a PR but i can tell you there are two more files having JText:: PHP code in it in this repo after doing a search:
joomla-cms/plugins/actionlog/joomla/joomla.php
Line 1154 in a1ae392
@TLWebdesign You've checked the staging branch, as far as I can see. On that branch they are ok, we only want to get rid of the JText is the 4.0-dev branch, as far as I know.
Hi @richard67 i checked the 4.0-dev branche. downloaded the package and did a search.
Maybe i posted the wrong links then here i guess. Will try to correct them :)
Hmm links are the same so i think i did it correctly tho. Very much a beginner on this so excuse me if it was incorrect tho.
What i did was download 4.0-dev branche and then did a search for JText:: on my Mac. Then looked those files up on github i the 4.0-dev staging branche and got the perma link of the corresponding line.
As far as I could check, @TLWebdesign findings are correct in 4.0-dev
There might come more of these JTexts when the upmerge from 3.10-dev will be continued.
@brianteeman Do you want to fix the 3 other places found by @TLWebdesign in the 4.0-dev branch? Or will you make another PR for these plus the other ones which might come when George continues the upmerge from 3.10-dev?
This is quite a low skilled job changing this. i wouldn't mind spending my time on this. So you guys can do more higher skilled stuff.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-06 09:27:47 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
@TLWebdesign definitely happy for you to do some PR's though - every bit definitely helps :)
Thanks!
thank you
I have tested this item✅ successfully on 08a9844
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33025.