Feeling Lucky
?
[#33001] - [4] Remove unused & undefined variables from sprintf
- Fixed in Code Base
- 5 Apr 2021
- Medium
- Build: 4.0-dev
- # 33001
- Diff
- PhilETaylor:patch-101
User tests: Successful: Unsuccessful:
Code review.
The subject of the sprintf only has 1 placeholder but yet we are providing 3 variables to it.
$err and $errno are also not defined before being used here
Psalm static analysis also highlights this as an issue.
ERROR: UndefinedVariable - libraries/src/Http/Transport/StreamTransport.php:166:72 - Cannot find referenced variable $err (see https://psalm.dev/024)
$php_errormsg = sprintf('Could not connect to resource: %s', $uri, $err, $errno);
ERROR: UndefinedVariable - libraries/src/Http/Transport/StreamTransport.php:166:78 - Cannot find referenced variable $errno (see https://psalm.dev/024)
$php_errormsg = sprintf('Could not connect to resource: %s', $uri, $err, $errno);
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
HLeithner
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-05 12:10:44 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||