Joomla 4.0-dev
Create an article with the word "create" and the word "admin" in the body text.
Ensure the System - Highlight plugin
is enabled
View the article on the frontend
Then append the url you are on with ?highlight=WyJjcmVhdGUiLCJhZG1pbiJd
WyJjcmVhdGUiLCJhZG1pbiJd
= base64encode of the array ["create","admin"]
View the source code.
The words admin
and create
to be highlighted.
The HTML source is there, but no css is applied to "highlight" the terms.
<span class="highlight" rel="create">create</span>
<span class="highlight" rel="admin">admin</span>
Safari on mac
Labels |
Added:
?
|
Hey @PhilETaylor
I would like to contribute in this issue Pls assign it to me
& can you brief me in which color you want it to be highlighted.
@PhilETaylor
the css exists but there is an error in it. Error comes from finder.css
we have
.result__item .highlight::before {
content: '';
position: absolute;
z-index: -1;
top: 50%;
left: 50%;
-webkit-transform: translate(-50%, -50%);
-ms-transform: translate(-50%, -50%);
transform: translate(-50%, -50%);
width: calc(100% + 6px);
height: calc(100% + 2px);
background: hsla(60, 100%, 50%, .5);
pointer-events: none;
border-radius: 3px;
}
Looks like taking off z-index: -1;
solves the issue. z-index can't work here as the body background is set to white.
Change has to be done in
I have done the changes RahulJha393@2f951b8
hope this solves the issue
@RahulJha393
This is the wrong place. The issue is for J4 and not J3/staging
The change would have to be done in
Then make a PR towards 4.0-dev
and then use npm to test.
Another solution is to add z-index: -2;
to the body.
@drmenzelit @chmst What do you think?
Ref which created this issue: 5725cbf#diff-a4d0ce450acf901b0a318d7e5dd759f1d3167cbc756c0be6c98bb1d125ed23db
@infograf768 Oops! OK let me check this out
@RahulJha393
Let's wait feed back from @drmenzelit @chmst
@RahulJha393
You got your answer. You can make the PR. :)
@RahulJha393
Will you do the PR ?
I would like to contribute in this issue Pls assign it to me
please read #31540 (comment)
if @prajjwal1231 is inactive, so should i proceed with the PR?
@himanshu007-creator first come, first serve ;-)
@infograf768
I am not getting any CSS that is applied to the highlight
class. Is there anything that is missing.
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-10 14:04:12 |
Closed_By | ⇒ | Quy |
Hey !! I would love to contribute to this. How can I share my code to help you highlighting the terms (i.e. "create" and "admin") . Kindly guide me